py3 print in numerical folder

[fchapoton]

another small step, trying to turn print to python3 behaviour

Component: python3

Author: Frédéric Chapoton, Matthias Koeppe

Branch/Commit: 4142421

Reviewer: Frédéric Chapoton, Matthias Koeppe

Issue created by migration from https://trac.sagemath.org/ticket/20548

[fchapoton]

Branch: public/20548

[fchapoton]

New commits:

5922fba

python3 print in numerical folder

[fchapoton]

Commit: 5922fba

[sagetrac-git]

Changed commit from 5922fba to cb257a0

[sagetrac-git]

Branch pushed to git repo; I updated commit sha1. New commits:

cb257a0

python3 print in numerical, details and fixing

[jdemeyer]

comment:3

Is this valid Python 3?

print

[jdemeyer]

comment:4

Well, it's technically valid but it doesn't do what you think it does:

Python 3.3.2 (default, Dec  7 2013, 12:59:33) 
[GCC 4.6.3] on linux
Type "help", "copyright", "credits" or "license" for more information.
>>> print
<built-in function print>

[jdemeyer]

comment:5

One more detail, since you're changing the code anyway. Change this

        if b.obj_constant_term > self._backend.zero(): print("+ {}".format(b.obj_constant_term))
        elif b.obj_constant_term < self._backend.zero(): print("- {}".format(-b.obj_constant_term))

to

        if b.obj_constant_term > self._backend.zero():
            print("+ {}".format(b.obj_constant_term))
        elif b.obj_constant_term < self._backend.zero():
            print("- {}".format(-b.obj_constant_term))

which is much more readable

[jdemeyer]

comment:6

Same for

        if d > self._backend.zero(): print("+ {} ".format(d))
        elif d < self._backend.zero(): print("- {} ".format(-d))

[sagetrac-git]

Changed commit from cb257a0 to ca3d653

[sagetrac-git]

Branch pushed to git repo; I updated commit sha1. New commits:

ca3d653

python3 print in numerical, fine tuning

[fchapoton]

comment:8

done

[mkoeppe]

comment:9

needs merge or rebase

[sagetrac-git]

Branch pushed to git repo; I updated commit sha1. New commits:

46fe07f

Merge branch 'public/20548' into 7.2.rc1

[sagetrac-git]

Changed commit from ca3d653 to 46fe07f

[mkoeppe]

comment:11

You missed several backends

[fchapoton]

comment:12

The aim is to have the doctests pass when adding a global future print import in sage/all.py.

For that, all the backends where something was needed were modified.

You can check this by adding from future import print_function in src/sage/all.py on top of this branch and running all the tests in the numerical folder.

If you want to take the opportunity to convert everything else to python3 print style in the numerical folder, please do.

[fchapoton]

comment:13

ping ?

[sagetrac-git]

Branch pushed to git repo; I updated commit sha1. New commits:

4142421

python3 print in remaining mip backends

[sagetrac-git]

Changed commit from 46fe07f to 4142421

[mkoeppe]

Changed author from Frédéric Chapoton to Frédéric Chapoton, Matthias Koeppe

[mkoeppe]

comment:15

Yes, as I said, you missed some backends.
I've done the remaining ones.

[fchapoton]

comment:16

ok, I had forgotten about the optional backends, indeed.

Why did you change two print to sys.stdout.write ?

[mkoeppe]

comment:17

Replying to @fchapoton:

Why did you change two print to sys.stdout.write ?

These are print-without-newlines.

[fchapoton]

comment:18

ok, then I am happy with your commit. Are you ok with mines ?

[mkoeppe]

comment:19

yes, looking good

[fchapoton]

comment:20

So, can I set to positive review ?

[mkoeppe]

comment:21

sure

[fchapoton]

Reviewer: Frédéric Chapoton, Matthias Koeppe

[fchapoton]

comment:22

done, thanks

[vbraun]

Changed branch from public/20548 to 4142421