Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add two Cython fixes #21126

Closed
jdemeyer opened this issue Jul 29, 2016 · 17 comments
Closed

Add two Cython fixes #21126

jdemeyer opened this issue Jul 29, 2016 · 17 comments

Comments

@jdemeyer
Copy link

See:

Upstream: Fixed upstream, but not in a stable release.

CC: @robertwb

Component: packages: standard

Author: Jeroen Demeyer

Branch/Commit: 24bc354

Reviewer: Nicolas M. Thiéry

Issue created by migration from https://trac.sagemath.org/ticket/21126

@jdemeyer
Copy link
Author

@jdemeyer
Copy link
Author

Commit: 093395e

@jdemeyer
Copy link
Author

New commits:

093395eAdd a Cython fix for cpdef methods

@jdemeyer

This comment has been minimized.

@jdemeyer jdemeyer changed the title Add a Cython fix for cpdef methods Add two Cython fixes Aug 17, 2016
@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Aug 17, 2016

Branch pushed to git repo; I updated commit sha1. New commits:

aa02833Fix Cython gdb debugging

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Aug 17, 2016

Changed commit from 093395e to aa02833

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Aug 17, 2016

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

24bc354Fix Cython gdb debugging

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Aug 17, 2016

Changed commit from aa02833 to 24bc354

@jdemeyer

This comment has been minimized.

@nthiery

This comment has been minimized.

@nthiery
Copy link
Contributor

nthiery commented Sep 6, 2016

comment:10

+1 on merging this as soon as Cython' PR #545 is merged. I did a ping on this PR.

@nthiery

This comment has been minimized.

@nthiery
Copy link
Contributor

nthiery commented Sep 6, 2016

comment:11

Robert just merged the PR. So positive review!

Thanks Robert :-)

@nthiery
Copy link
Contributor

nthiery commented Sep 6, 2016

Changed upstream from Reported upstream. No feedback yet. to Fixed upstream, but not in a stable release.

@nthiery

This comment has been minimized.

@nthiery
Copy link
Contributor

nthiery commented Sep 6, 2016

Reviewer: Nicolas M. Thiéry

@vbraun
Copy link
Member

vbraun commented Sep 8, 2016

Changed branch from u/jdemeyer/add_a_cython_fix_for_cpdef_methods to 24bc354

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants