Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

recognizable series (a base for k-regular sequences) #21295

Closed
dkrenn opened this issue Aug 19, 2016 · 63 comments
Closed

recognizable series (a base for k-regular sequences) #21295

dkrenn opened this issue Aug 19, 2016 · 63 comments
Labels
c: combinatorics p: major / 3 t: enhancement
Milestone
sage-9.4

Comments

@dkrenn
Copy link
Contributor

dkrenn commented Aug 19, 2016

Implement recognizable series, which are formal series, whose coefficients (each belongs to a word over an alphabet) satisfy a certain linear representation. (This linear representation is based on a monoid morphism into matrices.)

See also meta ticket #21202.

Depends on #30551

CC: @galipnik

Component: combinatorics

Keywords: thursdaysbdx

Author: Daniel Krenn

Branch/Commit: 42606e3

Reviewer: Sébastien Labbé, Clemens Heuberger

Issue created by migration from https://trac.sagemath.org/ticket/21295
@dkrenn dkrenn added this to the sage-7.4 milestone Aug 19, 2016
@dkrenn
Copy link
Contributor Author

dkrenn commented Aug 19, 2016

Branch: u/dkrenn/sequences/recognizable

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Aug 19, 2016

Commit: fd4f541

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Aug 19, 2016

Branch pushed to git repo; I updated commit sha1. New commits:

fd4f541move "transpose" in docstring to correct place

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Aug 22, 2016

Branch pushed to git repo; I updated commit sha1. New commits:

863d57aremove None-sense to simplify code
aec95ceextend element constructor
9e12383add experimental warning

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Aug 22, 2016

Changed commit from fd4f541 to 9e12383

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Aug 22, 2016

Changed commit from 9e12383 to 41874ba

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Aug 22, 2016

Branch pushed to git repo; I updated commit sha1. New commits:

41874bafix a typo

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Aug 25, 2016

Branch pushed to git repo; I updated commit sha1. New commits:

c7243a6Merge tag '7.4.beta1' into t/21295/sequences/recognizable

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Aug 25, 2016

Changed commit from 41874ba to c7243a6

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Aug 26, 2016

Branch pushed to git repo; I updated commit sha1. New commits:

352751eMerge tag '7.4.beta2' into t/21295/sequences/recognizable

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Aug 26, 2016

Changed commit from c7243a6 to 352751e

@cheuberg
Copy link
Contributor

cheuberg commented Jan 5, 2017

comment:10

patchbot python3 plugin failure

@cheuberg
Copy link
Contributor

cheuberg commented Jan 5, 2017

Dependencies: #21200

@cheuberg
Copy link
Contributor

cheuberg commented Jan 5, 2017

comment:11

6 of the 9 commits of #21200 are in this branch here, so #21200 should probably a dependency.

@cheuberg
Copy link
Contributor

Changed branch from u/dkrenn/sequences/recognizable to u/cheuberg/sequences/recognizable

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jan 12, 2017

Changed commit from 352751e to a6b5561

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jan 12, 2017

Branch pushed to git repo; I updated commit sha1. New commits:

a6b5561Trac #21295: fix ReST error

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jan 12, 2017

Changed commit from a6b5561 to c9c3408

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jan 12, 2017

Branch pushed to git repo; I updated commit sha1. New commits:

c9c3408Trac #21295: fix typos

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented May 6, 2021

Branch pushed to git repo; I updated commit sha1. New commits:

89f656bTrac #21295 review issue 33: rename to number_of_zeros (as it should be)
2ddb686Trac #21295 review issue 7: document accessing coefficients
13ad4a1Trac #21295 review issue 29: notice minimize vs field

@dkrenn
Copy link
Contributor Author

dkrenn commented May 6, 2021

comment:41

Replying to @cheuberg:

  1. I would also appreciate having an example in a very visible spot on how to access a coefficient.
    I think that unless someone guesses the __getitem__ method, they might have some hard time,
    in particular in view of the fact that the documentation of __getitem__ is not visible
    in the reference manual.

Added.

  1. In the module description, K is supposed to be a semiring. I fear that something bad might happen if that semiring is not a domain; "coefficients are automatically coerced to their fraction field." might then be inappropriate. As minimized is called by __bool__, the explanation added in minimized might not be enough.

Note added.

  1. RecognizableSeries._repr_.all_coefficients: I think that the variable name number_of_nonzeros is misleading: it seems to count the number of zeros since the last zero. So I think that number_of_zeros would be more appropriate.

Indeed; renamed.

New commits:

cbd187fTrac #21295: rename to coefficient_ring
89f656bTrac #21295 review issue 33: rename to number_of_zeros (as it should be)
2ddb686Trac #21295 review issue 7: document accessing coefficients
13ad4a1Trac #21295 review issue 29: notice minimize vs field

@dkrenn
Copy link
Contributor Author

dkrenn commented May 6, 2021

Last 10 new commits:

e9e7de2Trac #21295 review issue 14: document equivalent code for iterate_possible_additions
eaa7af5Trac #21295 review issue 17: linear_representation
b8746abTrac #21295 review issue 12: fix inconsistency in __iter__
7d68373Trac #21295: avoid minimization in repr
2f17011Trac #21295 review issue 29: Document that minimize uses fraction field
2b91fd8Trac #21295: fix typo "alphabeth"
cbd187fTrac #21295: rename to coefficient_ring
89f656bTrac #21295 review issue 33: rename to number_of_zeros (as it should be)
2ddb686Trac #21295 review issue 7: document accessing coefficients
13ad4a1Trac #21295 review issue 29: notice minimize vs field

@cheuberg
Copy link
Contributor

cheuberg commented May 6, 2021

comment:44

Thank you for your changes and comments. I have no further comments, feel free to set to positive once the patchbot is happy.

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented May 10, 2021

Branch pushed to git repo; I updated commit sha1 and set ticket back to needs_review. New commits:

42606e3Merge tag '9.3' into t/21295/sequences/recognizable

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented May 10, 2021

Changed commit from 13ad4a1 to 42606e3

@cheuberg
Copy link
Contributor

comment:48

I add dependency #30551 (Drop python 3.6 support): this ticket introduces occurrences of islice with an sage integer as an argument; this does not work with python 3.6.

An alternative would be to explicitly convert to an integer, but as #30551 is positively reviewed, this does not seem to be necessary.

@cheuberg
Copy link
Contributor

Dependencies: #30551

@vbraun
Copy link
Member

vbraun commented May 27, 2021

Changed branch from u/dkrenn/sequences/recognizable to 42606e3

@vbraun vbraun closed this as completed in 12831dd May 27, 2021
This was referenced Dec 29, 2022
Open
Closed
@galipnik galipnik mentioned this issue Jul 9, 2021
Closed
This was referenced Jan 29, 2023
Open
Open
dkrenn added a commit to dkrenn/sage that referenced this issue May 25, 2023
@dkrenn
Merge branch 't/21319/sequences/rec-hash' into t/21204/sequences/k-re…
bde8e67 
…gular-guess

* t/21319/sequences/rec-hash: (2030 commits)
  fix doctest output of TestSuite (new tests were added)
  Python3: fix iteritems
  Python3: xrange
  Python3: absolut import
  Python3: absolute import
  Python3: izip
  Python3: __nonzero__
  Trac sagemath#21295: fix typos
  Trac sagemath#21295: fix ReST error
  Updated SageMath version to 7.5
  Updated SageMath version to 7.5.rc3
  Use a deterministic sorting key for number fields
  Updated SageMath version to 7.5.rc2
  22136: pkg version/chksum
  Upgrade to Python 2.7.13
  Updated SageMath version to 7.5.rc1
  amending coment and message in setup.py
  Move autogen to a more appropriate location.
  22095: better doctest
  run tests only in spkg-check. Also run spkg-check with the same options as spkg-install
  ...
dkrenn added a commit to dkrenn/sage that referenced this issue May 25, 2023
@dkrenn
Merge branch 't/21319/sequences/rec-hash' into t/21204/sequences/k-re…
e726278 
…gular-guess

* t/21319/sequences/rec-hash: (11520 commits)
  Trac sagemath#21319: fixup due to changes in dependencies
  Trac sagemath#21318: fixup due to recent changes in dependencies
  Updated SageMath version to 9.3
  build/pkgs/fplll/spkg-install.in: Configure --without-qd if we use gcc from spkg
  build/pkgs/fplll/spkg-configure.m4: Add depcheck on gcc
  build/pkgs/ppl/spkg-configure.m4: Add depcheck on gcc
  build/pkgs/brial/spkg-configure.m4: Add depcheck on gcc
  build/pkgs/{freetype,libgd}/spkg-configure.m4: Add depcheck for gcc
  build/pkgs/zeromq/spkg-configure.m4: Add depcheck for gcc
  build/pkgs/ntl/spkg-configure.m4: Add depcheck for gcc
  Trac sagemath#21295 review issue 29: notice minimize vs field
  Trac sagemath#21295 review issue 7: document accessing coefficients
  Trac sagemath#21295 review issue 33: rename to number_of_zeros (as it should be)
  Trac sagemath#21203 review issue 4: rename to coefficient ring
  Trac sagemath#21295: rename to coefficient_ring
  Trac sagemath#21203 review issue 3: example for __getitem__ and __iter__
  Trac sagemath#21203 review issue 2: extend odds in Pascal's triangle
  Trac sagemath#21203 review issue 1: better binary sum of digits
  Trac sagemath#21203 review issue 5: meaningful error message in _n_to_index_
  Trac sagemath#21203 review issue 8: resolve "`n`th" in docstring
  ...
dkrenn added a commit to dkrenn/sage that referenced this issue Jul 4, 2023
@dkrenn
Merge branch 't/21204/sequences/k-regular-guess' into t/21343/k-regul…
e25b8d2 
…ar-warning

* t/21204/sequences/k-regular-guess: (2029 commits)
  fix doctest output of TestSuite (new tests were added)
  Python3: fix iteritems
  Python3: xrange
  Python3: absolut import
  Python3: absolute import
  Python3: izip
  Python3: __nonzero__
  Trac sagemath#21295: fix typos
  Trac sagemath#21295: fix ReST error
  Updated SageMath version to 7.5
  Updated SageMath version to 7.5.rc3
  Use a deterministic sorting key for number fields
  Updated SageMath version to 7.5.rc2
  22136: pkg version/chksum
  Upgrade to Python 2.7.13
  Updated SageMath version to 7.5.rc1
  amending coment and message in setup.py
  Move autogen to a more appropriate location.
  22095: better doctest
  run tests only in spkg-check. Also run spkg-check with the same options as spkg-install
  ...
dkrenn added a commit to dkrenn/sage that referenced this issue Jul 4, 2023
@dkrenn
Merge branch 't/21204/sequences/k-regular-guess' into t/21343/k-regul…
8488b55 
…ar-warning

* t/21204/sequences/k-regular-guess: (11522 commits)
  Trac sagemath#21204: fixup code and tests
  Trac sagemath#21204: cherry-pick to avoid merge conflict
  Trac sagemath#21319: fixup due to changes in dependencies
  Trac sagemath#21318: fixup due to recent changes in dependencies
  Updated SageMath version to 9.3
  build/pkgs/fplll/spkg-install.in: Configure --without-qd if we use gcc from spkg
  build/pkgs/fplll/spkg-configure.m4: Add depcheck on gcc
  build/pkgs/ppl/spkg-configure.m4: Add depcheck on gcc
  build/pkgs/brial/spkg-configure.m4: Add depcheck on gcc
  build/pkgs/{freetype,libgd}/spkg-configure.m4: Add depcheck for gcc
  build/pkgs/zeromq/spkg-configure.m4: Add depcheck for gcc
  build/pkgs/ntl/spkg-configure.m4: Add depcheck for gcc
  Trac sagemath#21295 review issue 29: notice minimize vs field
  Trac sagemath#21295 review issue 7: document accessing coefficients
  Trac sagemath#21295 review issue 33: rename to number_of_zeros (as it should be)
  Trac sagemath#21203 review issue 4: rename to coefficient ring
  Trac sagemath#21295: rename to coefficient_ring
  Trac sagemath#21203 review issue 3: example for __getitem__ and __iter__
  Trac sagemath#21203 review issue 2: extend odds in Pascal's triangle
  Trac sagemath#21203 review issue 1: better binary sum of digits
  ...
dkrenn added a commit to dkrenn/sage that referenced this issue Aug 3, 2023
@dkrenn
Merge branch 't/21343/k-regular-warning' into t/21202/k-regular-trunk
a8482ca 
* t/21343/k-regular-warning: (1709 commits)
  fix doctest output of TestSuite (new tests were added)
  Python3: fix iteritems
  Python3: xrange
  Python3: absolut import
  Python3: absolute import
  Python3: izip
  Python3: __nonzero__
  Trac sagemath#21295: fix typos
  Trac sagemath#21295: fix ReST error
  Updated SageMath version to 7.5
  Updated SageMath version to 7.5.rc3
  Use a deterministic sorting key for number fields
  Updated SageMath version to 7.5.rc2
  22136: pkg version/chksum
  Upgrade to Python 2.7.13
  Updated SageMath version to 7.5.rc1
  amending coment and message in setup.py
  Move autogen to a more appropriate location.
  22095: better doctest
  run tests only in spkg-check. Also run spkg-check with the same options as spkg-install
  ...
dkrenn added a commit to dkrenn/sage that referenced this issue Aug 3, 2023
@dkrenn
Merge branch 't/21343/k-regular-warning' into t/22964/k-regular-bounded
b44bdad 
* t/21343/k-regular-warning: (11523 commits)
  Trac sagemath#21343: adapt to removed transpose-property in dependency
  Trac sagemath#21204: fixup code and tests
  Trac sagemath#21204: cherry-pick to avoid merge conflict
  Trac sagemath#21319: fixup due to changes in dependencies
  Trac sagemath#21318: fixup due to recent changes in dependencies
  Updated SageMath version to 9.3
  build/pkgs/fplll/spkg-install.in: Configure --without-qd if we use gcc from spkg
  build/pkgs/fplll/spkg-configure.m4: Add depcheck on gcc
  build/pkgs/ppl/spkg-configure.m4: Add depcheck on gcc
  build/pkgs/brial/spkg-configure.m4: Add depcheck on gcc
  build/pkgs/{freetype,libgd}/spkg-configure.m4: Add depcheck for gcc
  build/pkgs/zeromq/spkg-configure.m4: Add depcheck for gcc
  build/pkgs/ntl/spkg-configure.m4: Add depcheck for gcc
  Trac sagemath#21295 review issue 29: notice minimize vs field
  Trac sagemath#21295 review issue 7: document accessing coefficients
  Trac sagemath#21295 review issue 33: rename to number_of_zeros (as it should be)
  Trac sagemath#21203 review issue 4: rename to coefficient ring
  Trac sagemath#21295: rename to coefficient_ring
  Trac sagemath#21203 review issue 3: example for __getitem__ and __iter__
  Trac sagemath#21203 review issue 2: extend odds in Pascal's triangle
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
c: combinatorics p: major / 3 t: enhancement
Projects
None yet
Milestone
sage-9.4
Development

No branches or pull requests
5 participants
@vbraun @seblabbe @fchapoton @cheuberg @dkrenn