Merge of GSoC modabvar project #21496

kevinywlui · 2016-09-14T22:27:00Z

This is a merge of this project: https://github.com/williamstein/sage_modabvar

Most of the code is checked against Magma. Here's a SMC worksheet checking most of the doctest examples: https://cloud.sagemath.com/projects/0d310a14-a099-47d9-87c7-df6b63af54a6/files/worksheets/magma_test_examples.sagews

The methods that aren't covered in the worksheet are:

is_J0, is_J1: they're really short
elliptic_curve: this checks that the newforms agree for conductor up to 50: all([S.newform(names='a') == S.elliptic_curve().newform() for N in [1..50] for S in J0(N) if S.dimension() == 1])
An algorithm for computing the divisor of order of the rational torsion subgroup is known in the J1(p) case. It is also conjecturally the order of the rational torsion subgroup. This is cover in this paper: http://math.stanford.edu/~conrad/papers/j1p.pdf and the code has been checked against the table in pg. 393.
newform_decomposition: This checks it against another way of computing it:

all([J0(N).newform_decomposition('a') == [S.newform('a') for S in J0(N)] for N in [1..50]])

all([J1(N).newform_decomposition('a') == [S.newform('a') for S in J1(N)] for N in [1..30]])

CC: @williamstein

Component: modular forms

Keywords: modular abelian variety

Author: Kevin Lui

Branch/Commit: 9500491

Reviewer: Frédéric Chapoton

Issue created by migration from https://trac.sagemath.org/ticket/21496

The text was updated successfully, but these errors were encountered:

kevinywlui · 2016-09-16T21:35:47Z

Branch: u/klui/merge_of_gsoc_modabvar_project

kevinywlui · 2016-09-19T03:50:07Z

New commits:

`d431329`	`Copied over files from Github repo. Made small docstring changes.`

kevinywlui · 2016-09-19T03:50:07Z

Changed dependencies from #20857 to none

kevinywlui · 2016-09-19T03:50:07Z

Author: Kevin Lui

kevinywlui · 2016-09-19T03:50:07Z

Commit: d431329

williamstein · 2016-09-20T01:12:59Z

comment:3

Quick comment: i pretty carefully refereed all the original code as it was being written, and had many (many!) comments on it, which Kevin addressed. So this is likely to be in pretty good shape.

fchapoton · 2016-09-28T09:20:34Z

comment:4

File "src/sage/modular/abvar/torsion_subgroup.py", line 421, in sage.modular.abvar.torsion_subgroup.RationalTorsionSubgroup.multiple_of_order
Failed example:
    from sage_modabvar import J0, J1
Exception raised:
    Traceback (most recent call last):
      File "/home/u1/chapoton/sage/local/lib/python2.7/site-packages/sage/doctest/forker.py", line 498, in _run
        self.compile_and_execute(example, compiler, test.globs)
      File "/home/u1/chapoton/sage/local/lib/python2.7/site-packages/sage/doctest/forker.py", line 861, in compile_and_execute
        exec(compiled, globs)
      File "<doctest sage.modular.abvar.torsion_subgroup.RationalTorsionSubgroup.multiple_of_order[0]>", line 1, in <module>
        from sage_modabvar import J0, J1
    ImportError: No module named sage_modabvar
**********************************************************************
File "src/sage/modular/abvar/torsion_subgroup.py", line 559, in sage.modular.abvar.torsion_subgroup.RationalTorsionSubgroup.multiple_of_order_using_frobp
Failed example:
    from sage_modabvar import JH
Exception raised:
    Traceback (most recent call last):
      File "/home/u1/chapoton/sage/local/lib/python2.7/site-packages/sage/doctest/forker.py", line 498, in _run
        self.compile_and_execute(example, compiler, test.globs)
      File "/home/u1/chapoton/sage/local/lib/python2.7/site-packages/sage/doctest/forker.py", line 861, in compile_and_execute
        exec(compiled, globs)
      File "<doctest sage.modular.abvar.torsion_subgroup.RationalTorsionSubgroup.multiple_of_order_using_frobp[20]>", line 1, in <module>
        from sage_modabvar import JH
    ImportError: No module named sage_modabvar

fchapoton · 2016-09-29T08:06:10Z

Changed branch from u/klui/merge_of_gsoc_modabvar_project to public/21496

fchapoton · 2016-09-29T08:06:10Z

Changed commit from d431329 to c760f00

fchapoton · 2016-09-29T08:06:10Z

comment:5

I made a public branch (based on u/klui/merge_of_gsoc_modabvar_project)
removing the 3 problematic imports.

New commits:

`53865b7`	`Merge branch 'u/klui/merge_of_gsoc_modabvar_project' in 7.4.b6`
`c760f00`	`removing some bad unused imports`

fchapoton · 2016-09-29T08:29:07Z

comment:6

one failing doctest:

File "src/sage/modular/abvar/abvar.py", line 4363, in sage.modular.abvar.abvar.ModularAbelianVariety_modsym_abstract.new_subvariety
Failed example:
    J0(33).new_subvariety()
Expected:
    Abelian subvariety of dimension 1 of J0(33)
Got:
    Simple abelian subvariety 33a(1,33) of dimension 1 of J0(33)

sagetrac-git · 2016-09-29T11:36:01Z

Branch pushed to git repo; I updated commit sha1. New commits:

`cf1aa03`	`trac 21496 fixing failing doctest`

sagetrac-git · 2016-09-29T11:36:01Z

Changed commit from c760f00 to cf1aa03

sagetrac-git · 2016-09-30T04:02:20Z

Branch pushed to git repo; I updated commit sha1. New commits:

`919e788`	`changed fix to failing doctest`

sagetrac-git · 2016-09-30T04:02:20Z

Changed commit from cf1aa03 to 919e788

kevinywlui · 2016-09-30T04:06:29Z

comment:9

@fchapoton Thanks for the fixes. I should have caught the bad imports earlier.

I think the doctest in new_subvariety fails because J0(33).is_simple() is called elsewhere in the file. There's a warning about this situation in L3203 in abvar.py . So I changed it to J0(34) since that isn't used anywhere in the file.

sagetrac-git · 2016-12-13T17:15:18Z

Branch pushed to git repo; I updated commit sha1. New commits:

`fcca7ac`	`Merge branch 'public/21496' in 7.5.b6`
`b8defb6`	`trac 21496 cosmetics of OUTPUT blocks`

sagetrac-git · 2016-12-13T17:15:18Z

Changed commit from 919e788 to b8defb6

fchapoton · 2016-12-13T17:16:33Z

comment:11

I have made a cosmetic commit, mainly about formatting the OUTPUT blocks.

If you do not object to these tiny changes, you can set a positive review on my behalf.

fchapoton · 2016-12-14T08:06:20Z

comment:12

oops, it seems that I broke the doc, let me fix that

sagetrac-git · 2016-12-14T09:01:19Z

Branch pushed to git repo; I updated commit sha1. New commits:

`3f92ea1`	`trac 21496 fixing doc, plus little code cleanup of ;`

sagetrac-git · 2016-12-14T09:01:19Z

Changed commit from b8defb6 to 3f92ea1

fchapoton · 2016-12-14T11:11:49Z

comment:14

ok, doc is good again.

Once again, if you agree with my small schanges, this can be set to positive.

kevinywlui · 2016-12-16T07:01:13Z

comment:15

Replying to @fchapoton:

ok, doc is good again.

Once again, if you agree with my small schanges, this can be set to positive.

Looks good to me. Thanks. I'll set it on your behalf.

fchapoton · 2017-01-05T16:57:10Z

Reviewer: Frédéric Chapoton

vbraun · 2017-01-17T23:21:03Z

comment:19

on 32-bit:

sage -t --long src/sage/modular/abvar/lseries.py
**********************************************************************
File "src/sage/modular/abvar/lseries.py", line 102, in sage.modular.abvar.lseries.Lseries_complex.__call__
Failed example:
    L(1) # long time (2s)
Expected:
    -1.33139759782370e-19
Got:
    -1.04128413920120e-19
**********************************************************************
File "src/sage/modular/abvar/lseries.py", line 201, in sage.modular.abvar.lseries.Lseries_complex.vanishes_at_1
Failed example:
    L(1) # long time (2s)
Expected:
    -1.33139759782370e-19
Got:
    -1.04128413920120e-19
^CKilling test src/sage/modular/abvar/lseries.py
----------------------------------------------------------------------
Doctests interrupted: 0/1 files tested
----------------------------------------------------------------------
Total time for all tests: 6.6 seconds
    cpu time: 0.0 seconds
    cumulative wall time: 0.0 seconds

Needs some # abs tol apparently

sagetrac-git · 2017-01-21T06:14:16Z

Changed commit from 3f92ea1 to 9500491

sagetrac-git · 2017-01-21T06:14:16Z

Branch pushed to git repo; I updated commit sha1. New commits:

`9500491`	`added abs tol to fix some failing test on 32bit`

kevinywlui · 2017-01-21T06:14:53Z

comment:21

Thanks for the catch. It should work now.

vbraun · 2017-01-21T21:21:52Z

Changed branch from public/21496 to 9500491

kevinywlui mannequin added this to the sage-7.4 milestone Sep 14, 2016

kevinywlui mannequin added c: modular forms labels Sep 14, 2016

This comment has been minimized.

Sign in to view

kevinywlui mannequin added the s: needs review label Sep 19, 2016

kevinywlui mannequin added s: positive review and removed s: needs review labels Dec 16, 2016

fchapoton modified the milestones: sage-7.4, sage-7.6 Jan 5, 2017

vbraun added s: needs work and removed s: positive review labels Jan 17, 2017

kevinywlui mannequin added s: needs review and removed s: needs work labels Jan 21, 2017

vbraun added s: positive review and removed s: needs review labels Jan 21, 2017

vbraun removed the s: positive review label Jan 21, 2017

vbraun closed this as completed in e6c3508 Jan 21, 2017

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Merge of GSoC modabvar project #21496

Merge of GSoC modabvar project #21496

kevinywlui mannequin commented Sep 14, 2016

kevinywlui mannequin commented Sep 16, 2016

kevinywlui mannequin commented Sep 19, 2016

kevinywlui mannequin commented Sep 19, 2016

kevinywlui mannequin commented Sep 19, 2016

This comment has been minimized.

kevinywlui mannequin commented Sep 19, 2016

williamstein commented Sep 20, 2016

fchapoton commented Sep 28, 2016

fchapoton commented Sep 29, 2016

fchapoton commented Sep 29, 2016

fchapoton commented Sep 29, 2016

fchapoton commented Sep 29, 2016

sagetrac-git mannequin commented Sep 29, 2016

sagetrac-git mannequin commented Sep 29, 2016

sagetrac-git mannequin commented Sep 30, 2016

sagetrac-git mannequin commented Sep 30, 2016

kevinywlui mannequin commented Sep 30, 2016

sagetrac-git mannequin commented Dec 13, 2016

sagetrac-git mannequin commented Dec 13, 2016

fchapoton commented Dec 13, 2016

fchapoton commented Dec 14, 2016

sagetrac-git mannequin commented Dec 14, 2016

sagetrac-git mannequin commented Dec 14, 2016

fchapoton commented Dec 14, 2016

kevinywlui mannequin commented Dec 16, 2016

fchapoton commented Jan 5, 2017

vbraun commented Jan 17, 2017

sagetrac-git mannequin commented Jan 21, 2017

sagetrac-git mannequin commented Jan 21, 2017

kevinywlui mannequin commented Jan 21, 2017

vbraun commented Jan 21, 2017

Merge of GSoC modabvar project #21496

Merge of GSoC modabvar project #21496

Comments

kevinywlui mannequin commented Sep 14, 2016

kevinywlui mannequin commented Sep 16, 2016

kevinywlui mannequin commented Sep 19, 2016

kevinywlui mannequin commented Sep 19, 2016

kevinywlui mannequin commented Sep 19, 2016

This comment has been minimized.

kevinywlui mannequin commented Sep 19, 2016

williamstein commented Sep 20, 2016

fchapoton commented Sep 28, 2016

fchapoton commented Sep 29, 2016

fchapoton commented Sep 29, 2016

fchapoton commented Sep 29, 2016

fchapoton commented Sep 29, 2016

sagetrac-git mannequin commented Sep 29, 2016

sagetrac-git mannequin commented Sep 29, 2016

sagetrac-git mannequin commented Sep 30, 2016

sagetrac-git mannequin commented Sep 30, 2016

kevinywlui mannequin commented Sep 30, 2016

sagetrac-git mannequin commented Dec 13, 2016

sagetrac-git mannequin commented Dec 13, 2016

fchapoton commented Dec 13, 2016

fchapoton commented Dec 14, 2016

sagetrac-git mannequin commented Dec 14, 2016

sagetrac-git mannequin commented Dec 14, 2016

fchapoton commented Dec 14, 2016

kevinywlui mannequin commented Dec 16, 2016

fchapoton commented Jan 5, 2017

vbraun commented Jan 17, 2017

sagetrac-git mannequin commented Jan 21, 2017

sagetrac-git mannequin commented Jan 21, 2017

kevinywlui mannequin commented Jan 21, 2017

vbraun commented Jan 21, 2017