Add a function to get the canonical joinands of an element of a lattice

[jm58660]

Add a function to get the canonical joinands of a lattice element.

Component: combinatorics

Author: Jori Mäntysalo

Branch/Commit: 1b5045e

Reviewer: Travis Scrimshaw

Issue created by migration from https://trac.sagemath.org/ticket/21597

[jm58660]

Branch: u/jmantysalo/canonical-joinands

[jm58660]

Commit: c9aa760

[jm58660]

New commits:

c9aa760

Add canonical_joinands().

[tscrim]

comment:3

You should include a test where it does not exist. Also, to be Python3 compatible, change iter.next() to next(iter).

[sagetrac-git]

Changed commit from c9aa760 to 1b5045e

[sagetrac-git]

Branch pushed to git repo; I updated commit sha1. New commits:

1b5045e

Py3-style next.

[jm58660]

comment:5

Replying to @tscrim:

You should include a test where it does not exist.

There is one already: L.canonical_joinands(6) is None.

Also, to be Python3 compatible, change iter.next() to next(iter).

Done.

[tscrim]

comment:6

Replying to @jm58660:

Replying to @tscrim:

You should include a test where it does not exist.

There is one already: L.canonical_joinands(6) is None.

Whoops, missed that.

Positive review.

[tscrim]

Reviewer: Travis Scrimshaw

[vbraun]

Changed branch from u/jmantysalo/canonical-joinands to 1b5045e