Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add canonical meetands #21601

Closed
jm58660 mannequin opened this issue Sep 26, 2016 · 6 comments
Closed

Add canonical meetands #21601

jm58660 mannequin opened this issue Sep 26, 2016 · 6 comments

Comments

@jm58660
Copy link
Mannequin

jm58660 mannequin commented Sep 26, 2016

For symmetry with #21597 after that has been closed.

CC: @tscrim

Component: combinatorics

Author: Jori Mäntysalo

Branch/Commit: cb7b710

Reviewer: Travis Scrimshaw

Issue created by migration from https://trac.sagemath.org/ticket/21601

@jm58660 jm58660 mannequin added this to the sage-7.4 milestone Sep 26, 2016
@jm58660 jm58660 mannequin added c: combinatorics labels Sep 26, 2016
@jm58660
Copy link
Mannequin Author

jm58660 mannequin commented Oct 23, 2016

Branch: u/jmantysalo/add_canonical_meetands

@jm58660
Copy link
Mannequin Author

jm58660 mannequin commented Oct 23, 2016

comment:2

Done this. The code is just a direct dual. To test try

n = 30; seed = 42; p = 0.999
set_random_seed(seed)
L = Posets.RandomLattice(n, p)
L_ = L.dual()
for e in L:
    if L.canonical_joinands(e) is None and L_.canonical_meetands(e) is None:
        continue
    if sorted(L.canonical_joinands(e)) != sorted(L_.canonical_meetands(e)):
        print("ERROR")
        break
else:
    print("OK")

New commits:

cb7b710Add canonical meetands.

@jm58660
Copy link
Mannequin Author

jm58660 mannequin commented Oct 23, 2016

Commit: cb7b710

@jm58660 jm58660 mannequin modified the milestones: sage-7.4, sage-7.5 Oct 23, 2016
@jm58660 jm58660 mannequin added the s: needs review label Oct 23, 2016
@tscrim
Copy link
Collaborator

tscrim commented Oct 23, 2016

comment:3

LGTM.

@tscrim
Copy link
Collaborator

tscrim commented Oct 23, 2016

Reviewer: Travis Scrimshaw

@vbraun
Copy link
Member

vbraun commented Nov 2, 2016

Changed branch from u/jmantysalo/add_canonical_meetands to cb7b710

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants