Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Workaround for failing complex_double test on Cygwin #21605

Closed
embray opened this issue Sep 28, 2016 · 9 comments
Closed

Workaround for failing complex_double test on Cygwin #21605

embray opened this issue Sep 28, 2016 · 9 comments

Comments

@embray
Copy link
Contributor

embray commented Sep 28, 2016

I fixed this a while ago, but realized I don't think I ever made a ticket for it.

This test fails due to minor numerical differences (again, probably originating in the log() function) so that the polynomial returned by z.algdep(5) ends up being slightly different (it gets an extra factor of x^2). This makes the test a little more flexible to such differences.

Component: porting: Cygwin

Branch/Commit: u/embray/bug/cygwin/complex_double_test @ 77feef0

Reviewer: Erik Bray

Issue created by migration from https://trac.sagemath.org/ticket/21605

@embray embray added this to the sage-7.4 milestone Sep 28, 2016
@embray
Copy link
Contributor Author

embray commented Apr 11, 2017

comment:1

#21292 remains stalled, but this simple test fix doesn't require it; better to just fix this.

@embray
Copy link
Contributor Author

embray commented Apr 11, 2017

Changed dependencies from #21292 to none

@embray

This comment has been minimized.

@embray embray modified the milestones: sage-7.4, sage-8.0 Apr 11, 2017
@jdemeyer
Copy link

comment:2

#22759 solves the same problem in a different (arguably better) way.

@embray
Copy link
Contributor Author

embray commented Apr 11, 2017

comment:3

Oh, that's new--I'll have a look.

@embray
Copy link
Contributor Author

embray commented Apr 11, 2017

comment:4

I see now--this should fix the underlying problem I think, but I'll have to test it.

@tscrim
Copy link
Collaborator

tscrim commented Apr 13, 2017

comment:5

Since #22759, I think we can close this as a dup.

@tscrim tscrim removed this from the sage-8.0 milestone Apr 13, 2017
@jdemeyer
Copy link

Changed author from Erik Bray to none

@jdemeyer
Copy link

Reviewer: Erik Bray

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants