Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ComplexDoubleElement.algdep(): use arith.misc.algdep #22759

Closed
jdemeyer opened this issue Apr 5, 2017 · 17 comments
Closed

ComplexDoubleElement.algdep(): use arith.misc.algdep #22759

jdemeyer opened this issue Apr 5, 2017 · 17 comments

Comments

@jdemeyer
Copy link

jdemeyer commented Apr 5, 2017

Depends on #22714

CC: @dimpase @embray

Component: basic arithmetic

Author: Dima Pasechnik

Branch/Commit: fd96c0a

Reviewer: Jeroen Demeyer, Erik Bray

Issue created by migration from https://trac.sagemath.org/ticket/22759

@jdemeyer jdemeyer added this to the sage-8.0 milestone Apr 5, 2017
@jdemeyer
Copy link
Author

jdemeyer commented Apr 5, 2017

Dependencies: #22714

@jdemeyer
Copy link
Author

jdemeyer commented Apr 5, 2017

comment:2

Remind me to work on this once #22714 has been merged (to avoid conflicts with other tickets).

@dimpase
Copy link
Member

dimpase commented Apr 5, 2017

Commit: 08b1862

@dimpase
Copy link
Member

dimpase commented Apr 5, 2017

comment:3

let's just get it done :-)


New commits:

2f6afb2Define `__abs__` for p-adic numbers
65ab385Factorize result of algdep()
08b1862fix for #22759

@dimpase
Copy link
Member

dimpase commented Apr 5, 2017

Changed author from Jeroen Demeyer to Jeroen Demeyer, Dima Pasechnik

@dimpase
Copy link
Member

dimpase commented Apr 5, 2017

Branch: u/dimpase/t22759

@dimpase
Copy link
Member

dimpase commented Apr 5, 2017

comment:4

well, wrong git base, but 08b1862 does the job.

@jdemeyer
Copy link
Author

jdemeyer commented Apr 6, 2017

Changed author from Jeroen Demeyer, Dima Pasechnik to Dima Pasechnik

@jdemeyer
Copy link
Author

jdemeyer commented Apr 6, 2017

comment:5

The branch is already red...

@embray
Copy link
Contributor

embray commented Apr 11, 2017

comment:7

This would probably fix #21605, but I need to double-check.

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Apr 11, 2017

Changed commit from 08b1862 to fd96c0a

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Apr 11, 2017

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

e53c199Merge branch 'u/jdemeyer/factorize_result_of_algdep__' of trac.sagemath.org:sage into dcfix
fd96c0afix for #22759

@dimpase
Copy link
Member

dimpase commented Apr 11, 2017

comment:9

rebased over the the branch of #22714
needs review; passes tests on linux and freebsd

@jdemeyer
Copy link
Author

Reviewer: Jeroen Demeyer

@embray
Copy link
Contributor

embray commented Apr 13, 2017

Changed reviewer from Jeroen Demeyer to Jeroen Demeyer, Erik Bray

@embray
Copy link
Contributor

embray commented Apr 13, 2017

comment:11

Confirmed that this fixes #21605 on Cygwin as well.

@vbraun
Copy link
Member

vbraun commented Apr 14, 2017

Changed branch from u/dimpase/t22759 to fd96c0a

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants