Standardize patches in fricas, frobby

[jdemeyer]

The packages fricas and frobby use non-standard patching.

CC: @embray @dimpase

Component: packages: experimental

Author: Jeroen Demeyer

Branch/Commit: 683e7b9

Reviewer: Matthias Koeppe

Issue created by migration from https://trac.sagemath.org/ticket/21721

[jdemeyer]

Branch: u/jdemeyer/standardize_patches_in_fricas__frobby__gap3

[jdemeyer]

New commits:

683e7b9

Standardize patches in fricas and frobby

[jdemeyer]

Commit: 683e7b9

[mantepse]

comment:3

I think that fricas shouldn't need the patch anymore, at least with #21377 (but I admit, I cannot package)

[mkoeppe]

comment:5

Cc'ing dimpase, who probably has a script that created the frobby patches.

[dimpase]

comment:6

Replying to @mkoeppe:

Cc'ing dimpase, who probably has a script that created the frobby patches.

no, I think I simply used git to create/update patches.

Otherwise, this simply moves things around, right?

[mkoeppe]

comment:7

This ticket edits the patch to make it -p1 instead of -p0
Wouldn't it be better if there was a public git of the modified frobby, and a script that regenerated the patches?

[jdemeyer]

comment:8

I don't think that we ever use scripts in Sage to generate patches...

[mkoeppe]

comment:9

I know that we don't (with some exceptions), but my point is that it would be better if we did.
Our patch management seems ad-hoc (in contrast for example to Debian's tools and documented workflow for this)
and few people seem to be aware of git format-patch, which can be used to create a set of patches.

[dimpase]

comment:10

I used git format-patch yesterday for the 1st time :-)

[mkoeppe]

comment:11

Nice. Let's add a short section on how to manage patchsets with git format-patch to the developers' guide...

[mkoeppe]

comment:12

This is #21781.

[mkoeppe]

Reviewer: Matthias Koeppe

[vbraun]

Changed branch from u/jdemeyer/standardize_patches_in_fricas__frobby__gap3 to 683e7b9