Update FriCAS to 1.3.2 (current)

[mantepse]

subject says it all, see ​http://fricas.sourceforge.net/

https://groups.google.com/forum/#!topic/fricas-devel/jjn0P3H0N8g

I assume that this version needs less patching.

Upstream source tarball:
https://sourceforge.net/projects/fricas/files/fricas/1.3.2/fricas-1.3.2-full.tar.bz2/download

(with ads, but automatic download after a few seconds)

CC: @dkrenn @mantepse @hemmecke @rwst

Component: packages: experimental

Keywords: FriCAS

Author: Frédéric Chapoton

Branch: 8aa26de

Reviewer: Martin Rubey

Issue created by migration from https://trac.sagemath.org/ticket/21377

[mantepse]

Changed keywords from none to FriCAS

[fchapoton]

Commit: d8be4f4

[fchapoton]

Branch: u/chapoton/21377

[fchapoton]

comment:2

I made a branch, removing one patch that failed to apply. Maybe this patch must be kept.

---

New commits:

d8be4f4

trac 21377 update fricas

[mantepse]

comment:3

Note that it's meanwhile 1.3.2. No idea whether there are significant changes.

[sagetrac-git]

Changed commit from d8be4f4 to 8aa26de

[sagetrac-git]

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

8aa26de

update fricas to 1.3.2

[fchapoton]

comment:7

This installs correctly and passes the "# optional fricas" doctests. Can someone double check please ?

[mantepse]

comment:8

I am currently compiling!

[mantepse]

comment:9

Hm, when trying to do sage -i fricas with this ticket, I get an error saying that it couldn't be downloaded...

How should I try this?

[mantepse]

comment:10

I think I figured it out: download and put it into upstream

[fchapoton]

comment:11

you need to put yourself the tar file in $SAGEHOME/upstream

[mantepse]

comment:12

I actually have most tests failing now, because of bad indentation. For example:

File "src/sage/interfaces/fricas.py", line 1104, in sage.interfaces.fricas.FriCASElement._sage_
Failed example:
    a = fricas('(1 + sqrt(2))^5'); a                              # optional - fricas
Expected:
       +-+
    29\|2  + 41
Got:
    +-+
    29 \|2  + 41

However, I cannot tell whether the tests passed before the switch to FriCAS 1.3.2.

[hemmecke]

comment:13

I guess the "+-+" part got a bit shifted when you copied the result into the ticket. The difference is the space after 29. This has recently been added.

[mantepse]

comment:14

I am not sure how to proceed - on the one hand, I think it makes sense to merge this, because I do not know what made the output break (I do not mean the additional space) - it was broken before the upgrade, too.

Frederic, can you confirm that the tests pass on your computer? It's strange that the space introduced in FriCAS would not show up on your system.

[mantepse]

comment:15

I can confirm it works and fixes part of #23782

[mantepse]

Author: Frédéric Chapoton

[mantepse]

Reviewer: Martin Rubey

[jdemeyer]

Replying to @mantepse:

(with ads, but automatic download after a few seconds)

I'm not sure that this will be acceptable for the release manager.

[mantepse]

comment:18

Replying to @jdemeyer:

Replying to @mantepse:

(with ads, but automatic download after a few seconds)

I'm not sure that this will be acceptable for the release manager.

Are you saying that sourceforge is not acceptable anymore?

[rwst]

comment:19

Replying to @mantepse:

Are you saying that sourceforge is not acceptable anymore?

https://en.wikipedia.org/wiki/SourceForge#Country_restrictions

They seem to at least willing to improve the site that declined after 2012:
https://www.reddit.com/r/sysadmin/comments/4n3e1s/the_state_of_sourceforge_since_its_acquisition_in/

[mantepse]

comment:20

Is https://github.com/fricas/fricas acceptable? But I have no idea how to package from there.

[hemmecke]

comment:21

Note that https://github.com/fricas/fricas is a only source repository. As far as I know, the release tarball is not identical to the git version that is tagged with the version number. The release tarball contains some precompiled stuff. (I'm not 100% sure since I compile myself from source.)
Ask on https://groups.google.com/forum/#!forum/fricas-devel how one can package from the source tree.

[mantepse]

comment:22

OK, I shot myself into the foot here. No, I'm sure we should want the sourceforge version here. PLEASE!

[rwst]

comment:23

Replying to @hemmecke:

Note that https://github.com/fricas/fricas is a only source repository.

So is https://github.com/pynac/pynac. The maintainer just uploads a suitable tarball when doing a release. This means you need to do at least one release in the repo.

[jdemeyer]

comment:24

I am not the release manager. I am only saying that it might be a problem for the release manager, just to save you some time before the release manager looks at this ticket.

[vbraun]

Changed branch from u/chapoton/21377 to 8aa26de

[mantepse]

comment:26

This is wonderful, wonderful, wonderful! Thank you!

[mantepse]

Changed commit from 8aa26de to none