Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to PARI 2.9.1 #21756

Closed
jdemeyer opened this issue Oct 24, 2016 · 61 comments
Closed

Upgrade to PARI 2.9.1 #21756

jdemeyer opened this issue Oct 24, 2016 · 61 comments

Comments

@jdemeyer
Copy link

Tarball: http://pari.math.u-bordeaux.fr/pub/pari/unix/pari-2.9.1.tar.gz

Numerous doctests have to be changed, due to different outputs from PARI (in particular the unit group of number fields).

One doctest change is potentially dubious but has been checked by John Cremona:

         It can happen that no points are found if the height bounds
         used in the search are too small (see :trac:`10745`)::
 
             sage: K.<y> = NumberField(x^4 + x^2 - 7)
             sage: E = EllipticCurve(K, [1, 0, 5*y^2 + 16, 0, 0])
             sage: E.gens(lim1=1, lim3=1)
             []
-            sage: E.rank(), E.gens()  # long time (about 3 s)
-            (1, [(9/25*y^2 + 26/25 : -229/125*y^3 - 67/25*y^2 - 731/125*y - 213/25 : 1)])
+            sage: E.rank(), E.gens(lim3=12)  # long time (about 4s)
+            (1,
+             [(369/25*y^3 + 539/25*y^2 + 1178/25*y + 1718/25 : -29038/125*y^3 - 43003/125*y^2 - 92706/125*y - 137286/125 : 1)])

I had to increase the lim3 value for Simon's 2-descent to find a point. The new point differs from the old point by a 3-torsion point and a sign.

CC: @pjbruin @JohnCremona @kedlaya @jpflori

Component: packages: standard

Keywords: atelierpari2017

Author: Jeroen Demeyer

Branch/Commit: 1d577e1

Reviewer: John Cremona, Jean-Pierre Flori, Vincent Delecroix

Issue created by migration from https://trac.sagemath.org/ticket/21756

@jdemeyer
Copy link
Author

Dependencies: #21765

@jdemeyer
Copy link
Author

jdemeyer commented Nov 2, 2016

Changed dependencies from #21765 to #21703

@jdemeyer
Copy link
Author

jdemeyer commented Nov 2, 2016

Branch: u/jdemeyer/upgrade_to_pari_2_8_1

@jdemeyer
Copy link
Author

jdemeyer commented Nov 3, 2016

Commit: a7099ae

@jdemeyer

This comment has been minimized.

@jdemeyer
Copy link
Author

jdemeyer commented Nov 3, 2016

New commits:

313b785Interface PARI precision in bits
f80485fRemove obsolete comment about stack increasing
b70ec86Add reference to precision guide in PariInstance.__init__
b4bc24fMerge tag '7.5.beta1' into t/21703/ticket/21703
3db3275Only use precisions which are in [33,64] mod 64
a7099aeImprove documentation

@jdemeyer jdemeyer changed the title Upgrade to PARI 2.8.1 Upgrade to PARI 2.9.0 Nov 3, 2016
@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Nov 3, 2016

Branch pushed to git repo; I updated commit sha1. New commits:

457bf64Upgrade to PARI 2.9.0

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Nov 3, 2016

Changed commit from a7099ae to 457bf64

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Nov 4, 2016

Changed commit from 457bf64 to 0f226f7

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Nov 4, 2016

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

0f226f7Upgrade to PARI 2.9.0

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Nov 4, 2016

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

920252aUpgrade to PARI 2.9.0

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Nov 4, 2016

Changed commit from 0f226f7 to 920252a

@jdemeyer

This comment has been minimized.

@jdemeyer

This comment has been minimized.

@jdemeyer

This comment has been minimized.

@jpflori
Copy link

jpflori commented Nov 18, 2016

comment:12

CC'ing random number theory people.

Given that the sum of the two result is of 3-torsion, the new point is still a generator, so should we really worry?
@jdemeyer: do you think the precision change is worrying?

@JohnCremona
Copy link
Member

comment:13

Nothing to worry about (in answer to the first question). The algorithm is computing E(Q)/2E(Q) anyway.

@jdemeyer
Copy link
Author

comment:14

My worry is that PARI 2.8.0 found a point with the default settings of Simon's 2-descent, while PARI 2.9.0 does not find a point (it only finds a point after increasing some bound).

@kiwifb
Copy link
Member

kiwifb commented Nov 22, 2016

comment:15

I am having trouble with the new stackwarn patch and a pristine pari-2.9.0 tarball.

patching file src/gp/gp.c
patching file src/language/init.c
Hunk #1 succeeded at 740 (offset -34 lines).
Hunk #2 succeeded at 755 (offset -34 lines).
Hunk #3 FAILED at 804.
1 out of 3 hunks FAILED -- saving rejects to file src/language/init.c.rej

Am I doing something wrong?

@jdemeyer
Copy link
Author

comment:16

The two patches need to be applied in order.

@kiwifb
Copy link
Member

kiwifb commented Nov 22, 2016

comment:17

I see!

@jpflori
Copy link

jpflori commented Nov 29, 2016

comment:18

Did you ask about the prec issue on pari-devel?

@jdemeyer
Copy link
Author

comment:19

Replying to @jpflori:

Did you ask about the prec issue on pari-devel?

No. Do you think that I should? It's not really a PARI issue, but a potential issue with the 2-descent script.

@jpflori
Copy link

jpflori commented Nov 29, 2016

comment:20

Sure, but Karim or someone else there could be more knowledgeable than us.

@jdemeyer

This comment has been minimized.

@jdemeyer
Copy link
Author

jdemeyer commented Jan 3, 2017

comment:35

[comment:25] is an upstream bug :-(

@jdemeyer
Copy link
Author

jdemeyer commented Jan 3, 2017

comment:36

It's not an upstream bug, it's fallout from prot_none.patch.

@jdemeyer
Copy link
Author

jdemeyer commented Jan 3, 2017

Changed upstream from Reported upstream. No feedback yet. to none

@jdemeyer

This comment has been minimized.

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jan 4, 2017

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

99bb049Upgrade to PARI 2.9.1
5e91b6dUpdate prot_none.patch

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jan 4, 2017

Changed commit from 768635d to 5e91b6d

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jan 4, 2017

Changed commit from 5e91b6d to a0feccc

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jan 4, 2017

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

a0fecccUpdate prot_none.patch

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jan 4, 2017

Changed commit from a0feccc to f7fabb3

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jan 4, 2017

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

f7fabb3Update prot_none.patch

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jan 5, 2017

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

d60ae83Upgrade to PARI 2.9.1
3da9565Update prot_none.patch

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jan 5, 2017

Changed commit from f7fabb3 to 3da9565

@jdemeyer
Copy link
Author

jdemeyer commented Jan 5, 2017

comment:42

This now passes all tests on 32-bit and 64-bit.

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jan 8, 2017

Changed commit from 3da9565 to 1d577e1

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jan 8, 2017

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

b1c66bdUpgrade to PARI 2.9.1
1d577e1Update prot_none.patch

@videlec
Copy link
Contributor

videlec commented Jan 9, 2017

Changed reviewer from John Cremona, Jean-Pierre Flori to John Cremona, Jean-Pierre Flori, Vincent Delecroix

@videlec
Copy link
Contributor

videlec commented Jan 9, 2017

comment:44

Probably unrelated but I had one doctest failure running all tests in parallel

sage -t src/sage/libs/gap/assigned_names.py  # 1 doctest failed

I am not able to reproduce it.

@videlec
Copy link
Contributor

videlec commented Jan 10, 2017

Changed keywords from none to atelierpari2017

@vbraun
Copy link
Member

vbraun commented Jan 18, 2017

Changed branch from u/jdemeyer/upgrade_to_pari_2_8_1 to 1d577e1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants