New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade to PARI 2.9.1 #21756
Comments
Dependencies: #21765 |
Branch: u/jdemeyer/upgrade_to_pari_2_8_1 |
Commit: |
This comment has been minimized.
This comment has been minimized.
New commits:
|
Branch pushed to git repo; I updated commit sha1. New commits:
|
Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:
|
Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:
|
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
comment:12
CC'ing random number theory people. Given that the sum of the two result is of 3-torsion, the new point is still a generator, so should we really worry? |
comment:13
Nothing to worry about (in answer to the first question). The algorithm is computing E(Q)/2E(Q) anyway. |
comment:14
My worry is that PARI 2.8.0 found a point with the default settings of Simon's 2-descent, while PARI 2.9.0 does not find a point (it only finds a point after increasing some bound). |
comment:15
I am having trouble with the new stackwarn patch and a pristine pari-2.9.0 tarball.
Am I doing something wrong? |
comment:16
The two patches need to be applied in order. |
comment:17
I see! |
comment:18
Did you ask about the prec issue on pari-devel? |
comment:19
Replying to @jpflori:
No. Do you think that I should? It's not really a PARI issue, but a potential issue with the 2-descent script. |
comment:20
Sure, but Karim or someone else there could be more knowledgeable than us. |
This comment has been minimized.
This comment has been minimized.
comment:35
[comment:25] is an upstream bug :-( |
comment:36
It's not an upstream bug, it's fallout from |
Changed upstream from Reported upstream. No feedback yet. to none |
This comment has been minimized.
This comment has been minimized.
Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:
|
Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:
|
comment:42
This now passes all tests on 32-bit and 64-bit. |
Changed reviewer from John Cremona, Jean-Pierre Flori to John Cremona, Jean-Pierre Flori, Vincent Delecroix |
comment:44
Probably unrelated but I had one doctest failure running all tests in parallel
I am not able to reproduce it. |
Changed keywords from none to atelierpari2017 |
Changed branch from u/jdemeyer/upgrade_to_pari_2_8_1 to |
Tarball: http://pari.math.u-bordeaux.fr/pub/pari/unix/pari-2.9.1.tar.gz
Numerous doctests have to be changed, due to different outputs from PARI (in particular the unit group of number fields).
One doctest change is potentially dubious but has been checked by John Cremona:
I had to increase the
lim3
value for Simon's 2-descent to find a point. The new point differs from the old point by a 3-torsion point and a sign.CC: @pjbruin @JohnCremona @kedlaya @jpflori
Component: packages: standard
Keywords: atelierpari2017
Author: Jeroen Demeyer
Branch/Commit:
1d577e1
Reviewer: John Cremona, Jean-Pierre Flori, Vincent Delecroix
Issue created by migration from https://trac.sagemath.org/ticket/21756
The text was updated successfully, but these errors were encountered: