Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename gen -> Gen #22185

Closed
jdemeyer opened this issue Jan 13, 2017 · 7 comments
Closed

Rename gen -> Gen #22185

jdemeyer opened this issue Jan 13, 2017 · 7 comments
Labels
c: interfaces p: major / 3 t: enhancement
Milestone
sage-7.6

Comments

@jdemeyer
Copy link

For consistency, use a capital for the class name.

This will also allow from .gen import Gen in __init__.py (which doesn't work if the class has the same name as the module).

Depends on #21756
Depends on #21806
Depends on #21807
Depends on #21808
Depends on #21809
Depends on #21810
Depends on #22183

CC: @defeo @videlec

Component: interfaces

Keywords: atelierpari2017

Author: Jeroen Demeyer

Branch/Commit: 0c4433c

Reviewer: Vincent Delecroix

Issue created by migration from https://trac.sagemath.org/ticket/22185
@jdemeyer jdemeyer added this to the sage-7.6 milestone Jan 13, 2017
@jdemeyer
Copy link
Author

Changed keywords from none to atelierpari2017

@jdemeyer
Copy link
Author

Branch: u/jdemeyer/ticket/22185

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jan 13, 2017

Commit: 0c4433c

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jan 13, 2017

Branch pushed to git repo; I updated commit sha1. New commits:

0c4433cFix documentation

@videlec
Copy link
Contributor

videlec commented Jan 18, 2017

Reviewer: Vincent Delecroix

@jdemeyer
Copy link
Author

comment:7

Thanks!

@vbraun
Copy link
Member

vbraun commented Jan 23, 2017

Changed branch from u/jdemeyer/ticket/22185 to 0c4433c

@vbraun vbraun closed this as completed in 2481901 Jan 23, 2017
@jdemeyer jdemeyer mentioned this issue Apr 29, 2017
Closed
@videlec videlec mentioned this issue Jan 29, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
c: interfaces p: major / 3 t: enhancement
Projects
None yet
Milestone
sage-7.6
Development

No branches or pull requests
3 participants
@vbraun @jdemeyer @videlec