Make "tightpage=True" the default behavior for view

[mo271]

The original implementation of view, produces a pdf in a4 format,
regardless of the typeset object. #6591 introduced the tightpage
option which produces a document whose size matches the typeset
object.

Since then, the tightpage=True option has grown popular; in fact
most of the time, this is the desirable choice. Therefore this ticket
makes tightpage=True the default.

Note: in some cases, the current implementation of tightpage crops the
border of the picture. This will be fixed in a separate ticket to make
tightpage even more appealing.

CC: @jplab @nthiery

Component: misc

Keywords: days79, latex

Author: Moritz Firsching

Branch/Commit: 1bf4697

Reviewer: Jean-Philippe Labbé

Issue created by migration from https://trac.sagemath.org/ticket/21929

[mo271]

Commit: 7f932ca

[mo271]

New commits:

7f932ca

Fixing ticket 21929

[mo271]

Branch: u/moritz/ticket/21929

[sagetrac-git]

Branch pushed to git repo; I updated commit sha1. New commits:

15d6d2f

Changed documentation to indicate the new default behavior

[sagetrac-git]

Changed commit from 7f932ca to 15d6d2f

[mo271]

comment:3

I would like to remove the many occurrences of tightpage=True in various files to reflect the new defaults.

[sagetrac-git]

Branch pushed to git repo; I updated commit sha1. New commits:

800b051

removed occurances of 'tightpage=true'

[sagetrac-git]

Changed commit from 15d6d2f to 800b051

[mo271]

Author: moritz

[jplab]

comment:6

Hi Moritz,

Did you make a circular search do look for all instances of "tightpage=(T)true"?

[jplab]

Reviewer: Jean-Philippe Labbé

[jplab]

Changed author from moritz to Moritz Firsching

[jplab]

comment:8

Hi Moritz,

Could you also adapt the text in the documentation of view concerning the option "tightpage" so that it makes sense with the updated default value. For example, say what it does when it is set to "False".

[jplab]

comment:9

All test passed on Sage7.5.b3.

[sagetrac-git]

Branch pushed to git repo; I updated commit sha1. New commits:

bf273fa

more improvements in the documentation

[sagetrac-git]

Changed commit from 800b051 to bf273fa

[mo271]

comment:11

I searched for all instances of tightpage=True and hopefully didn't miss any.

The last commit addresses the changes in the documentation you suggest.

---

New commits:

bf273fa

more improvements in the documentation

[jplab]

comment:12

Great! All test passed.

I would like to have a second opinion. Nicolas, anything to say about the patch?

This looks good for a positive review on my part.

[sagetrac-git]

Changed commit from bf273fa to 397cd78

[sagetrac-git]

Branch pushed to git repo; I updated commit sha1. New commits:

397cd78

fixed one more occurance

[jplab]

comment:14

Dear Moritz,

I did a pep8 check on latex.py. Could you remove the "blanklines containing whitespaces" and "trailing whitespaces" in line 2101 and 2103, 2118 of latex.py.

JP

[nthiery]

comment:17

For the record: we made a quick poll here at Sage Days 79, and everybody who cared voted to make tightpage=True the default.

[sagetrac-git]

Branch pushed to git repo; I updated commit sha1. New commits:

1bf4697

removed some whitespace

[sagetrac-git]

Changed commit from 397cd78 to 1bf4697

[jplab]

comment:19

Looks ok to me now. I'm setting it to positive review.

[vbraun]

Changed branch from u/moritz/ticket/21929 to 1bf4697