Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

py3 a few cmp removed in crypto, dynamics (py files) #21971

Closed
fchapoton opened this issue Nov 25, 2016 · 16 comments
Closed

py3 a few cmp removed in crypto, dynamics (py files) #21971

fchapoton opened this issue Nov 25, 2016 · 16 comments
Labels
c: python3 p: major / 3 t: enhancement
Milestone
sage-7.5

Comments

@fchapoton
Copy link
Contributor

as a very minor step to py3

CC: @tscrim @jdemeyer @a-andre

Component: python3

Author: Frédéric Chapoton

Branch/Commit: 2829a7f

Reviewer: Travis Scrimshaw

Issue created by migration from https://trac.sagemath.org/ticket/21971
@fchapoton fchapoton added this to the sage-7.5 milestone Nov 25, 2016
@fchapoton
Copy link
Contributor Author

New commits:

242b93bconvert a few cmp to richcmp in crypto, dynamics, finance

@fchapoton
Copy link
Contributor Author

Commit: 242b93b

@fchapoton
Copy link
Contributor Author

Branch: u/chapoton/21971

@fchapoton fchapoton changed the title py3 a few cmp removed in crypto, finance, dynamics py3 a few cmp removed in crypto, finance, dynamics (py files) Dec 2, 2016
@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Dec 2, 2016

Changed commit from 242b93b to b48b6d5

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Dec 2, 2016

Branch pushed to git repo; I updated commit sha1. New commits:

4bf45ecMerge branch 'u/chapoton/21971' in 7.5.b5
b48b6d5trac 21971 a solution for cmp in flat_surfaces/strata

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Dec 2, 2016

Branch pushed to git repo; I updated commit sha1. New commits:

c2c08db21971 another fix by stepping back to __cmp__

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Dec 2, 2016

Changed commit from b48b6d5 to c2c08db

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Dec 4, 2016

Branch pushed to git repo; I updated commit sha1. New commits:

314a0e8trac 21971 one typo, still not working

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Dec 4, 2016

Changed commit from c2c08db to 314a0e8

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Dec 4, 2016

Changed commit from 314a0e8 to 2829a7f

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Dec 4, 2016

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

2829a7fconvert a few cmp to richcmp in crypto, dynamics, finance

@fchapoton fchapoton changed the title py3 a few cmp removed in crypto, finance, dynamics (py files) py3 a few cmp removed in crypto, dynamics (py files) Dec 4, 2016
@fchapoton
Copy link
Contributor Author

comment:8

ping

@fchapoton
Copy link
Contributor Author

comment:9

ping

this should be an easy review..

@tscrim
Copy link
Collaborator

tscrim commented Dec 11, 2016

Reviewer: Travis Scrimshaw

@tscrim
Copy link
Collaborator

tscrim commented Dec 11, 2016

comment:10

This will work for now as a __cmp__ between different parents does not make sense.

@vbraun
Copy link
Member

vbraun commented Dec 13, 2016

Changed branch from u/chapoton/21971 to 2829a7f

@vbraun vbraun closed this as completed in ba3ba8b Dec 13, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
c: python3 p: major / 3 t: enhancement
Projects
None yet
Milestone
sage-7.5
Development

No branches or pull requests
3 participants
@vbraun @tscrim @fchapoton