-
-
Notifications
You must be signed in to change notification settings - Fork 452
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Inconsistent handling of exact function arguments #22142
Comments
comment:1
I have a Pynac patch that does this:
However, the question is raised if you don't want this for all functions, and if you do, if we want to hold all functions with exact arguments (except where we have a simplified representation, i.e., a closed form that is simpler than the function expression). EDIT: or if not all functions, then which? |
comment:2
BTW
|
Changed keywords from none to Pynac |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Dependencies: pynac-0.7.4 |
comment:4
Replying to @rwst:
Good. Thanks :)
IMHO yes, we want this for all symbolic functions, as no exact value should get inexact. What would be the drawbacks? |
comment:5
Replying to @dkrenn:
No drawbacks. I just needed confirmation. |
comment:6
For completeness, I mention the sage-devel thread on gamma(QQbar(...)) |
Branch: u/dkrenn/t/22142 |
Author: Daniel Krenn |
Commit: |
Changed dependencies from pynac-0.7.4 to #22219 pynac-0.7.4 |
New commits:
|
Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:
|
comment:10
Is fine modulo the dependency. |
Reviewer: Ralf Stephan |
comment:11
The dependency needs to be a ticket number... |
comment:13
Replying to @vbraun:
Ticket number was already there; just the "pynac..." has not been removed. |
Changed branch from u/dkrenn/t/22142 to |
At the moment we have
and
So the logarithm of an exact value loses the exactness.
I would expect a symbolic expression
where the argument is the symbolic encapsulation of
QQbar(sqrt(2))
(for the same reason why the logarithm of the integer 2 becomes the symboliclog(2)
.This is fixed for all
GinacFunctions
in Pynac git master. The ticket should doctest them in the resp. files undersage/functions
.Depends on #22219
CC: @behackl @cheuberg
Component: algebra
Keywords: Pynac
Author: Daniel Krenn
Branch/Commit:
c252b4d
Reviewer: Ralf Stephan
Issue created by migration from https://trac.sagemath.org/ticket/22142
The text was updated successfully, but these errors were encountered: