Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Creating an order in a number field --> infinite loop? #2216

Closed
craigcitro opened this issue Feb 20, 2008 · 6 comments
Closed

Creating an order in a number field --> infinite loop? #2216

craigcitro opened this issue Feb 20, 2008 · 6 comments

Comments

@craigcitro
Copy link
Member

So I just tried the following:

sage: F.<alpha> = NumberField(x**4+3)
sage: F.order([alpha**2], allow_subfield=True)

and it seemed to go into an infinite loop. (Maybe I'm impatient, but it doesn't seem like it should take more than 2 seconds to do this, nevermind the minute I waited.) I haven't looked to see what the problem is at all.

Component: number theory

Issue created by migration from https://trac.sagemath.org/ticket/2216

@aghitza
Copy link

aghitza commented Apr 25, 2008

comment:1

It was indeed an infinite loop in absolute_order_from_module_generators(). See the attached patch.

@craigcitro
Copy link
Member Author

comment:2

Looks good, with one trivial change: I think we should take out the line that says "This shows that trac #2216 has been fixed." This is useful to people editing the code, but not to the user -- and that's who the docstring should be for ...

@craigcitro craigcitro changed the title Creating an order in a number field --> infinite loop? [with patch, with 99% positive review] Creating an order in a number field --> infinite loop? Apr 26, 2008
@aghitza
Copy link

aghitza commented Apr 26, 2008

revised patch

@aghitza
Copy link

aghitza commented Apr 26, 2008

comment:3

Attachment: 2216-order_bug.patch.gz

I've replaced the patch with one in which "trac #2216 has been fixed" is changed into something more informative for the user ("an order in a subfield").

@aghitza aghitza changed the title [with patch, with 99% positive review] Creating an order in a number field --> infinite loop? Creating an order in a number field --> infinite loop? Apr 26, 2008
@sagetrac-mabshoff
Copy link
Mannequin

sagetrac-mabshoff mannequin commented Apr 26, 2008

comment:4

I still think that mentioning the trac ticket when adding a specific doctest is a good thing. So combining both, i.e. a description that is useful for the user as well as (fixes #2216) in a good compromise.

Cheers,

Michael

@sagetrac-mabshoff
Copy link
Mannequin

sagetrac-mabshoff mannequin commented Apr 26, 2008

comment:5

Merged in Sage 3.0.1.alpha0

@sagetrac-mabshoff sagetrac-mabshoff mannequin closed this as completed Apr 26, 2008
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants