New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
splitting field function for number fields #2217
Comments
comment:1
Note that this approach does not give the splitting field. It gives a field containing at least one root of each factor of the original polynomial, but that still might not be the splitting field. Later in the thread mentioned above, I give a technique using internals of qqbar which I believe does give the splitting field (perhaps inefficiently). |
This comment has been minimized.
This comment has been minimized.
Add splitting_field() function |
comment:5
Attachment: 2217_splitting_field.patch.gz |
comment:6
Jeroen, what is the status of the patch here? |
comment:7
I totally forgot about this. I might be good to revisit this. |
comment:8
I originally had plans for some speed-ups, but since the code works fine, I guess it can be reviewed. |
Author: Jeroen Demeyer |
comment:9
I ran all standard tests, and everything passed. I was trying to test functionality, but I'm confused by the differences file. All of the old examples seem to work, and none of the new ones work. In the first example, I get:
The expected output seems to have been changed from this result to
These fields are isomorphic, but I've tried the example on three machines, and all of them give the first thing as the output. Similarly, the second example doesn't work:
But the original example (now deleted) does work:
|
This comment has been minimized.
This comment has been minimized.
comment:10
Attachment: trac_2217_correction.patch.gz here is a patch to correct the failing doctest let us see if the bot is happy apply 2217_splitting_field.patch trac_2217_correction.patch |
comment:12
ok, the bot is happy. Now the ticket needs review. |
Branch pushed to git repo; I updated commit sha1. New commits:
|
This comment has been minimized.
This comment has been minimized.
comment:26
I am looking at your new commits. At first I assumed that your commits were based on mine uploaded earlier, but when pulling yours on top of mine failed I guessed the truth. This is of course fine -- except that some people might now argue otherwise: during the time when my commit was attached to this ticket, it is possible that other people pulled it and based further work, new tickets etc, all on my unreviewed commit. That would have been stupid of them, but some of the comments on the recent sage-devel thread make it clear that git purists would never so this. I won't tell anyone if you do not! ;) |
comment:27
Replying to @JohnCremona:
I absolutely understand your point, but I think I indicated that this was work in progress so I felt it was safe to "rewrite history". Now that it's Concerning authorship: I did indeed reset the author name back to myself ( |
comment:28
Understood. I am happy (and quite impressed!) with the new code and am just testing, using the verbose option so I can see what is happening. |
Branch pushed to git repo; I updated commit sha1. New commits:
|
Branch pushed to git repo; I updated commit sha1. New commits:
|
comment:31
Still needs-review or will you be making more commits?! |
comment:32
Code looks very good, and I am happy with the results of testing. I have looked at the commits on branch u/jdemeyer/ticket/2217 up to commit c50eb3e... |
comment:33
Thanks, I didn't expect such a quick review. Am I allowed to add more examples/doctests? |
comment:34
Replying to @jdemeyer:
Of course! I think there are already a lot of examples, which I liked. If you are going to make some more changes I would be happy to look at them, so I'll now mark the ticket as needs work, and when you are ready put it back to needs review. While you are at it, the description of the class containing a pair (polynomial, degree multiple) is slightly confusing since it refers to other polynomials in the class, whereas you actually deal with lists of instances of these. I am currently working on another branch so the next review will not be so quick! |
comment:35
Replying to @JohnCremona:
In that case, perhaps I prefer to leave this ticket and continue on a new ticket. Sorry for the mess. |
We should add
splitting_field()
function: given a polynomial, compute the number field generated by all the roots.See the thread at http://groups.google.com/group/sage-devel/browse_thread/thread/32fe12de12d5f6a5/c91753b5e65fe7b9#c91753b5e65fe7b9
Follow-up tickets: #11905, #15626
CC: @abrochard
Component: number fields
Author: Jeroen Demeyer
Branch/Commit: u/jdemeyer/ticket/2217 @
c50eb3e
Reviewer: John Cremona, Frédéric Chapoton
Issue created by migration from https://trac.sagemath.org/ticket/2217
The text was updated successfully, but these errors were encountered: