Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove _pari_instance global #22222

Closed
jdemeyer opened this issue Jan 21, 2017 · 16 comments
Closed

Remove _pari_instance global #22222

jdemeyer opened this issue Jan 21, 2017 · 16 comments

Comments

@jdemeyer
Copy link

The _pari_instance global in src/sage/libs/cypari2/pari_instance.pxd was introduced as temporary workaround. Ideally, it should not be needed.

Since many of the uses of pari_instance involve lists, I decided to create a new function cdef Gen list_of_Gens_to_Gen(list s) for fast conversion of a Python list of Gens to a Gen. This function is in turn called from objtogen.

CC: @defeo @videlec

Component: interfaces

Author: Jeroen Demeyer

Branch/Commit: 98869b4

Reviewer: Luca De Feo

Issue created by migration from https://trac.sagemath.org/ticket/22222

@jdemeyer jdemeyer added this to the sage-7.6 milestone Jan 21, 2017
@jdemeyer

This comment has been minimized.

@jdemeyer
Copy link
Author

Author: Jeroen Demeyer

@jdemeyer jdemeyer changed the title Remove pari_instance global in gen.pyx Remove _pari_instance global Jan 23, 2017
@jdemeyer
Copy link
Author

Dependencies: #22185

@jdemeyer

This comment has been minimized.

@jdemeyer
Copy link
Author

Changed dependencies from #22185 to #22185, #22210

@jdemeyer

This comment has been minimized.

@jdemeyer
Copy link
Author

Branch: u/jdemeyer/ticket/22222

@jdemeyer
Copy link
Author

Commit: 2d82cf9

@jdemeyer
Copy link
Author

New commits:

de81adcTrac 22210: remove obsolete special case in PARI gen.eval()
7a35c89Merge commit '6022cab1880d6f3820e0f028671ddd2983eae42b'; commit 'ee54f071a26c63821f475d2832c7bb1fbbdd7e95' into ticket/22183
235efd3Rename PariInstance -> Pari
6f04abaRemove unused imports from sage
c258dcaRename gen -> Gen
0c4433cFix documentation
dbaf3b2Merge remote-tracking branch 'trac/u/jdemeyer/ticket/22185' into HEAD
2d82cf9Remove _pari_instance global

@jdemeyer
Copy link
Author

jdemeyer commented Feb 2, 2017

Changed dependencies from #22185, #22210 to none

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Feb 2, 2017

Changed commit from 2d82cf9 to 98869b4

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Feb 2, 2017

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

98869b4Remove _pari_instance global

@defeo
Copy link
Member

defeo commented Feb 3, 2017

Reviewer: Luca De Feo

@defeo
Copy link
Member

defeo commented Feb 3, 2017

comment:12

Good for me. I cannot reproduce the doctest timeout reported by patchbot.

Wondering about bernfrac, bernreal, and fibonacci. What is this L type in pari.desc?

@jdemeyer
Copy link
Author

jdemeyer commented Feb 3, 2017

comment:13

L = C long

@vbraun
Copy link
Member

vbraun commented Feb 4, 2017

Changed branch from u/jdemeyer/ticket/22222 to 98869b4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants