New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove _pari_instance global #22222
Comments
This comment has been minimized.
This comment has been minimized.
Author: Jeroen Demeyer |
Dependencies: #22185 |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Branch: u/jdemeyer/ticket/22222 |
Commit: |
New commits:
|
Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:
|
Reviewer: Luca De Feo |
comment:12
Good for me. I cannot reproduce the doctest timeout reported by patchbot. Wondering about |
comment:13
|
Changed branch from u/jdemeyer/ticket/22222 to |
The
_pari_instance
global insrc/sage/libs/cypari2/pari_instance.pxd
was introduced as temporary workaround. Ideally, it should not be needed.Since many of the uses of
pari_instance
involve lists, I decided to create a new functioncdef Gen list_of_Gens_to_Gen(list s)
for fast conversion of a Python list ofGen
s to aGen
. This function is in turn called fromobjtogen
.CC: @defeo @videlec
Component: interfaces
Author: Jeroen Demeyer
Branch/Commit:
98869b4
Reviewer: Luca De Feo
Issue created by migration from https://trac.sagemath.org/ticket/22222
The text was updated successfully, but these errors were encountered: