Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

py3: simplify richcmp of integer ring and polynomial classes #22379

Closed
fchapoton opened this issue Feb 13, 2017 · 18 comments
Closed

py3: simplify richcmp of integer ring and polynomial classes #22379

fchapoton opened this issue Feb 13, 2017 · 18 comments

Comments

@fchapoton
Copy link
Contributor

By getting rid of the calls to _richcmp.

This is a first step towards the aim of getting rid of _richcmp everywhere. There will remain to handle 2 other calls elsewhere.

CC: @jm58660 @tscrim @a-andre @jdemeyer

Component: python3

Author: Frédéric Chapoton

Branch/Commit: 58890e5

Reviewer: Travis Scrimshaw

Issue created by migration from https://trac.sagemath.org/ticket/22379

@fchapoton fchapoton added this to the sage-7.6 milestone Feb 13, 2017
@fchapoton
Copy link
Contributor Author

New commits:

1564b84py3 : try to simplify (rich)cmp of IntegerRing_class

@fchapoton
Copy link
Contributor Author

Commit: 1564b84

@fchapoton
Copy link
Contributor Author

Branch: u/chapoton/22379

@jdemeyer
Copy link

comment:2

I'd rather fix this as part of #22344.

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Feb 18, 2017

Branch pushed to git repo; I updated commit sha1. New commits:

5212fb8Merge branch 'u/chapoton/22379' in 7.6.b4
6fde126trac 22379 get rid of _richcmp in polynomials

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Feb 18, 2017

Changed commit from 1564b84 to 6fde126

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Feb 20, 2017

Changed commit from 6fde126 to 0e41382

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Feb 20, 2017

Branch pushed to git repo; I updated commit sha1. New commits:

0e41382trac 22379 some doctests fixed

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Feb 20, 2017

Changed commit from 0e41382 to 1284b26

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Feb 20, 2017

Branch pushed to git repo; I updated commit sha1. New commits:

1284b26trac 22379 fixing doctests in a better way

@fchapoton
Copy link
Contributor Author

comment:6

it seems that the bot is mostly green, please review

@fchapoton

This comment has been minimized.

@fchapoton fchapoton changed the title py3: try to simplify richcmp of integer ring class py3: simplify richcmp of integer ring and polynomial classes Feb 21, 2017
@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Feb 21, 2017

Branch pushed to git repo; I updated commit sha1. New commits:

58890e5trac 22379 undo one unnecessary change

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Feb 21, 2017

Changed commit from 1284b26 to 58890e5

@fchapoton
Copy link
Contributor Author

comment:8

Bot is now squarely green.

This is a simplification of the comparison framework. Once the same thing is done in #22427 for the remaining 2 calls to _richcmp (in complex numbers), one will be able to get rid of _richcmp. Let me recall that handling the comparison is one of the major problems standing on our way to python3.

@tscrim
Copy link
Collaborator

tscrim commented Feb 24, 2017

comment:9

While I fundamentally agree with Jeroen, I think it is better for us to make progress in the more immediate as work on #22344 has currently stalled.

@tscrim
Copy link
Collaborator

tscrim commented Feb 24, 2017

Reviewer: Travis Scrimshaw

@vbraun
Copy link
Member

vbraun commented Feb 26, 2017

Changed branch from u/chapoton/22379 to 58890e5

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants