New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
py3: simplify richcmp of integer ring and polynomial classes #22379
Comments
New commits:
|
Commit: |
Branch: u/chapoton/22379 |
comment:2
I'd rather fix this as part of #22344. |
Branch pushed to git repo; I updated commit sha1. New commits:
|
Branch pushed to git repo; I updated commit sha1. New commits:
|
comment:6
it seems that the bot is mostly green, please review |
This comment has been minimized.
This comment has been minimized.
Branch pushed to git repo; I updated commit sha1. New commits:
|
comment:8
Bot is now squarely green. This is a simplification of the comparison framework. Once the same thing is done in #22427 for the remaining 2 calls to |
comment:9
While I fundamentally agree with Jeroen, I think it is better for us to make progress in the more immediate as work on #22344 has currently stalled. |
Reviewer: Travis Scrimshaw |
Changed branch from u/chapoton/22379 to |
By getting rid of the calls to
_richcmp
.This is a first step towards the aim of getting rid of
_richcmp
everywhere. There will remain to handle 2 other calls elsewhere.CC: @jm58660 @tscrim @a-andre @jdemeyer
Component: python3
Author: Frédéric Chapoton
Branch/Commit:
58890e5
Reviewer: Travis Scrimshaw
Issue created by migration from https://trac.sagemath.org/ticket/22379
The text was updated successfully, but these errors were encountered: