Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

py3: remove usage of _richcmp in complex fields #22427

Closed
fchapoton opened this issue Feb 23, 2017 · 6 comments
Closed

py3: remove usage of _richcmp in complex fields #22427

fchapoton opened this issue Feb 23, 2017 · 6 comments
Labels
c: python3 p: major / 3 t: enhancement
Milestone
sage-7.6

Comments

@fchapoton
Copy link
Contributor

as a simplification of comparison of parents.

similar to #22379

once both are closed, one can remove _richcmp itself.

Component: python3

Author: Frédéric Chapoton

Branch/Commit: 4f3cbca

Reviewer: Travis Scrimshaw

Issue created by migration from https://trac.sagemath.org/ticket/22427
@fchapoton fchapoton added this to the sage-7.6 milestone Feb 23, 2017
@fchapoton
Copy link
Contributor Author

Commit: 4f3cbca

@fchapoton
Copy link
Contributor Author

Branch: u/chapoton/22427

@fchapoton
Copy link
Contributor Author

New commits:

4f3cbcapy3: remove usage of `_richcmp` in complex fields

@fchapoton fchapoton changed the title py3: remove usage of _richcmp in coomplex fields py3: remove usage of _richcmp in complex fields Feb 23, 2017
@tscrim
Copy link
Collaborator

tscrim commented Feb 24, 2017

comment:3

LGTM.

@tscrim
Copy link
Collaborator

tscrim commented Feb 24, 2017

Reviewer: Travis Scrimshaw

@vbraun
Copy link
Member

vbraun commented Feb 26, 2017

Changed branch from u/chapoton/22427 to 4f3cbca

@vbraun vbraun closed this as completed in 648e355 Feb 26, 2017
@fchapoton fchapoton mentioned this issue Mar 1, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
c: python3 p: major / 3 t: enhancement
Projects
None yet
Milestone
sage-7.6
Development

No branches or pull requests
3 participants
@vbraun @tscrim @fchapoton