Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc cleanup in ell_rational_field #22413

Closed
fchapoton opened this issue Feb 22, 2017 · 9 comments
Closed

doc cleanup in ell_rational_field #22413

fchapoton opened this issue Feb 22, 2017 · 9 comments
Labels
c: elliptic curves p: major / 3 t: enhancement
Milestone
sage-7.6

Comments

@fchapoton
Copy link
Contributor

some spring cleanup, just for the documentation in the file ell_rational_field.py

also removes methods that were deprecated in #8118 (some time ago!)

CC: @JohnCremona @categorie @roed314

Component: elliptic curves

Author: Frédéric Chapoton

Branch/Commit: 3c5e3ba

Reviewer: John Cremona

Issue created by migration from https://trac.sagemath.org/ticket/22413
@fchapoton fchapoton added this to the sage-7.6 milestone Feb 22, 2017
@fchapoton
Copy link
Contributor Author

Branch: u/chapoton/22413

@fchapoton
Copy link
Contributor Author

New commits:

3c5e3basome doc cleanup in ell_rational_field and 2 neighbor files

@fchapoton
Copy link
Contributor Author

Commit: 3c5e3ba

@JohnCremona
Copy link
Member

comment:2

I read through the diffs and all looks good. Because of the removal of deprecated functions, I think I had better actually run some tests too...

@fchapoton
Copy link
Contributor Author

comment:3

I just launched my bot on the ticket, should be done in 3 hours approx.

@JohnCremona
Copy link
Member

comment:4

OK -- I only tested the elliptic_curves directory which will not take long (many cores): tests pass.

You can give yourself a positive review when your own tests finish successfully.

@JohnCremona
Copy link
Member

Reviewer: John Cremona

@fchapoton
Copy link
Contributor Author

comment:5

green bot, setting to positive, thanks for the review

@vbraun
Copy link
Member

vbraun commented Feb 26, 2017

Changed branch from u/chapoton/22413 to 3c5e3ba

@vbraun vbraun closed this as completed in 9d2e16b Feb 26, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
c: elliptic curves p: major / 3 t: enhancement
Projects
None yet
Milestone
sage-7.6
Development

No branches or pull requests
3 participants
@vbraun @JohnCremona @fchapoton