New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
split off Galois representations and modular parametrization from ell_rational_field.py #8118
Comments
comment:1
This patch is my first proposal for changes. It will also allow me to work more on the Galois representation side. For instance I deleted the second output of non-surjective since it was not used anywhere. I will build this in later in a different way, while also improving the outputs. Let me know if you think these changes go too far. What was the decision on deprecation policy of sage ? Is my handling here the correct one ? What is a I have first to test it myself, before I set it to "needs review". |
comment:3
I approve of this, though I don't have time to look at the patch right now. |
comment:4
I don't understand this. I exported the patch after adding the two new files to hg. Then I apply it to a new clone. The patch applies fine and the tests pass. But when I do -docbuild reference html it tells me that it can not find the new files :
I must be doing something stupidly wrong. Help ! |
updated. |
comment:5
Attachment: trac_8118.patch.gz I applied the patch to 4.3.2.alpha1: OK with some fuzz on hunk #7. Tests in sage/schemes/elliptic_curves: all tests (includng long) pass. sage -docbuild reference html worked fine for me (it warned about
but that's not from this patch!) I have not actually looked at the html docs for the new files yet, but will do so. Meanwhile: positive review. |
comment:6
My queue for 4.3.3.alpha0 is
Could you let me know how I should apply #8118 and #4453? Thanks! |
Work Issues: rebase against Sage 4.3.3.alpha0 |
comment:7
I get hunk failures when applying trac_8118.patch to Sage 4.3.3.alpha0:
Perhaps the attachment needs a rebase. |
Attachment: trac_8118_rebased.2.patch.gz exported against 4.3.3.alpha0 |
comment:8
No, that patch is not good. I will have to modify BSD.py, too. |
comment:9
OK. so let's hope I did it correctly this time. The patch trac_8118_rebased.patch can be applied to 4.3.3.alpha0. Please apply it before any other patch for ell_rational_field, since it is likely to break again. |
comment:10
Sorry, I tried to do things too quickly.. |
Attachment: trac_8118_rebased.patch.gz exported against 4.3.3.alpha0 |
comment:11
OK. This time, I think I got it right. The patch trac_8118_rebased.patch should apply fine to 4.3.3.alpha0. As said before, it should be applied before any other patch involving ell_rational_field, because I reordered the imports in the beginning of this file. On my machine all tests pass. (Except for a problem in heegner.py which is already there on 4.3.3.alpha0.) I don't know if I am allowed to set this back to positive review, since it is only a rebase. So I put a need_review instead. But it would be good if it gets in 4.3.3. |
Changed work issues from rebase against Sage 4.3.3.alpha0 to none |
comment:12
The rebase looks good. No drama when doctesting. |
Reviewer: John Cremona, Minh Van Nguyen |
Author: Chris Wuthrich |
comment:13
Merged trac_8118_rebased.patch. |
Merged: sage-4.3.3.alpha1 |
The file ell_rational_field.py is huge and should be split up further. This is especially important for the documentation, currently it is not very user-friendy to find a function in the reference.
I propose a first change.
The modular paratrization class goes into a separate file. (maybe the modular_degree should mover there too ?)
The functions concerning the Galois representation are moved to a separate field. I changed the functions like
is_surjective
andis_irreducible
to deprecated. I believe for instance the latter clashes with the irreducibility of the scheme E.CC: @JohnCremona @williamstein @robertwb @roed314
Component: elliptic curves
Keywords: galois representation, modular parametrization
Author: Chris Wuthrich
Reviewer: John Cremona, Minh Van Nguyen
Merged: sage-4.3.3.alpha1
Issue created by migration from https://trac.sagemath.org/ticket/8118
The text was updated successfully, but these errors were encountered: