New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add an option to the test runner to exit immediately upon the first failure #22832
Comments
Commit: |
Author: Erik Bray |
Branch: u/embray/tests/fail-once |
Replying to @embray:
Obvious question: why not call the Sage option |
comment:3
I'm making some changes, hang on... |
Changed branch from u/embray/tests/fail-once to u/jdemeyer/tests/fail-once |
This comment has been minimized.
This comment has been minimized.
Reviewer: Jeroen Demeyer |
comment:6
I'm fine with that, thanks. |
comment:7
Replying to @jdemeyer:
I personally find "fail once" to be clearer than "exit first"--"Exit first what?" is what it makes me ask. That said, the documentation makes it clear enough, and I don't mind the consistency. |
comment:8
Oops, one little nitpick--you forgot to remove the line |
Branch pushed to git repo; I updated commit sha1. New commits:
|
Changed branch from u/jdemeyer/tests/fail-once to |
Inspired by the
--exitfirst
option topy.test
, this adds a--exitfirst
option to Sage's test runner to exit immediately upon the first test failure.I've wanted something like this at several points, but one reason in particular is that part of the build of the patchbot Docker image is to perform the baseline test run, so that the image itself can be reused without having to rebuild the baseline each time. Obviously, if a test fails during the baseline test run then I want the Docker image build to fail immediately, and not wait until the rest of the test suite has run.
Component: doctest framework
Author: Erik Bray
Branch/Commit:
c6a5b40
Reviewer: Jeroen Demeyer
Issue created by migration from https://trac.sagemath.org/ticket/22832
The text was updated successfully, but these errors were encountered: