Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade to Cython 0.26 #23360

Closed
jdemeyer opened this issue Jul 4, 2017 · 33 comments
Closed

Upgrade to Cython 0.26 #23360

jdemeyer opened this issue Jul 4, 2017 · 33 comments
Labels
c: packages: standard p: major / 3 t: enhancement
Milestone
sage-8.0

Comments

@jdemeyer
Copy link

jdemeyer commented Jul 4, 2017

This allows us to use an unpatched version of Cython again.

Tarball: https://pypi.python.org/packages/10/d5/753d2cb5073a9f4329d1ffed1de30b0458821780af8fdd8ba1ad5adb6f62/Cython-0.26.tar.gz

CC: @embray

Component: packages: standard

Author: Jeroen Demeyer

Branch/Commit: 44030be

Reviewer: Erik Bray

Issue created by migration from https://trac.sagemath.org/ticket/23360
@jdemeyer jdemeyer added this to the sage-8.0 milestone Jul 4, 2017
@jdemeyer

This comment has been minimized.

Sign in to view
@jdemeyer

This comment has been minimized.

Sign in to view
@jdemeyer
Copy link
Author

jdemeyer commented Jul 4, 2017

Branch: u/jdemeyer/upgrade_to_cython_0_26

@embray
Copy link
Contributor

embray commented Jul 4, 2017

comment:4

Needs review?

New commits:

325763fUpgrade to Cython 0.26

@embray
Copy link
Contributor

embray commented Jul 4, 2017

Commit: 325763f

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jul 4, 2017

Changed commit from 325763f to b263b70

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jul 4, 2017

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

b263b70Upgrade to Cython 0.26

@jdemeyer
Copy link
Author

jdemeyer commented Jul 4, 2017

comment:6

Replying to @embray:

Needs review?

No, Cython 0.26 is not released yet. This is just for testing the beta version now.

@jdemeyer

This comment has been minimized.

Sign in to view
@jdemeyer

This comment has been minimized.

Sign in to view
@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jul 12, 2017

Changed commit from b263b70 to 68b11ba

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jul 12, 2017

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

68b11baUpgrade to Cython 0.26

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jul 12, 2017

Changed commit from 68b11ba to 5528784

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jul 12, 2017

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

5528784Upgrade to Cython 0.26

@jdemeyer

This comment has been minimized.

Sign in to view
@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jul 15, 2017

Changed commit from 5528784 to c6126ff

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jul 15, 2017

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

c6126ffUpgrade to Cython 0.26

@jdemeyer

This comment has been minimized.

Sign in to view
@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jul 19, 2017

Changed commit from c6126ff to ce5a03f

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jul 19, 2017

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

ce5a03fUpgrade to Cython 0.26

@jdemeyer

This comment has been minimized.

Sign in to view
@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jul 20, 2017

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

44030beUpgrade to Cython 0.26

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jul 20, 2017

Changed commit from ce5a03f to 44030be

@videlec
Copy link
Contributor

videlec commented Jul 20, 2017

comment:18

I launched the test suite on quasar (Ubuntu x86_64). Build was successfull.

@videlec
Copy link
Contributor

videlec commented Jul 20, 2017

comment:19

Replying to @videlec:

I launched the test suite on quasar (Ubuntu x86_64). Build was successfull.

And all tests pass.

@embray
Copy link
Contributor

embray commented Jul 20, 2017

comment:20

Windows patchbot just got to it.

@fchapoton
Copy link
Contributor

comment:21

Patchbots will do nothing for this kind of spkg ticket.

@embray
Copy link
Contributor

embray commented Jul 20, 2017

comment:22

Ah, I keep forgetting that. Why is that? You'd think one would want them to test new packages?

@fchapoton
Copy link
Contributor

comment:23

For safety reason, and because not so many people care about enhancing the patchbots. I have done my share.

@embray
Copy link
Contributor

embray commented Jul 20, 2017

comment:24

If there were safety issues with an upstream package wouldn't we want to know that in the patchbots first, before just declaring them "fine" and then pushing them on all users?

@embray
Copy link
Contributor

embray commented Jul 20, 2017

Reviewer: Erik Bray

@embray
Copy link
Contributor

embray commented Jul 20, 2017

comment:25

Compiles fine on Cygwin.

@vbraun
Copy link
Member

vbraun commented Jul 26, 2017

Changed branch from u/jdemeyer/upgrade_to_cython_0_26 to 44030be

@vbraun vbraun closed this as completed in 4ade915 Jul 26, 2017
@fchapoton fchapoton mentioned this issue Aug 11, 2017
Closed
@jdemeyer jdemeyer mentioned this issue Jul 31, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
c: packages: standard p: major / 3 t: enhancement
Projects
None yet
Milestone
sage-8.0
Development

No branches or pull requests
5 participants
@embray @vbraun @jdemeyer @fchapoton @videlec