Ship Sebastian Pancratz's deformation code

[jpflori]

Tarball at:
http://perso.telecom-paristech.fr/~flori/sage/deformation-d05941b.tar.bz2

Original code from Sebastian at:
https://github.com/SPancratz/deformation/
modified by JP:
https://github.com/jpflori/deformation/

Depends on #23466

CC: @edgarcosta @vbraun

Component: packages: optional

Keywords: sd87

Author: Jean-Pierre Flori

Branch: 76009ed

Reviewer: Edgar Costa

Issue created by migration from https://trac.sagemath.org/ticket/23498

[jpflori]

Changed keywords from none to sd87

[sagetrac-git]

Changed commit from 10f88ff to 2baec50

[sagetrac-git]

Branch pushed to git repo; I updated commit sha1. New commits:

2baec50

Use git commit sha1 as version for the moment.

[sagetrac-git]

Branch pushed to git repo; I updated commit sha1. New commits:

af22d83

Update deformation to include license.

[sagetrac-git]

Changed commit from 2baec50 to af22d83

[videlec]

comment:5

In the flint declaration file you are giving access to the precise structure of the C struct, namely

cdef extern from "flint/fmpz_poly.h":
    ctypedef struct fmpz_poly_struct:
        fmpz* coeffs
        long alloc
        long length

This not part of the public API of flint and would better be avoided in public Cython headers. Moreover, flint provides macros for accessing them. Please change to

cdef extern from "flint/fmpz_poly.h":
    ctypedef struct fmpz_poly_struct:
        pass

[videlec]

comment:6

BTW, what these flint declarations have to do with the ticket!?

[jpflori]

comment:7

These changes are from #23466.
I added flint types there and cleaned up the previous pxd files a little bit.
I agree we could live without the internal data structure of flint but I did not check we never actually use them in sage.

[jpflori]

Dependencies: #23466

[jpflori]

comment:8

(Note that I did not expand the fmpz_poly declaration, I just moved it so that it appears at a more natural place in types.pxd.)

[sagetrac-git]

Changed commit from af22d83 to 76009ed

[sagetrac-git]

Branch pushed to git repo; I updated commit sha1. New commits:

76009ed

Typo.

[vbraun]

comment:11

Reviewer name missing

[jpflori]

Reviewer: Edgar Costa

[vbraun]

Changed branch from u/jpflori/deformation to 76009ed

[kiwifb]

Changed commit from 76009ed to none

[kiwifb]

comment:14

Probably need a follow up because #23179 was merged at the same time. spkg-check and spkg-install shouldn't start with #!/usr/bin/env bash or equivalent anymore and they shouldn't be executable (644 instead of the current 755) either.

[jpflori]

comment:15

And it also seems I forgot to update the ticket description with the latest tarball version.
The correct one is at:

• http://perso.telecom-paristech.fr/~flori/sage/deformation-d05941b.tar.bz2

@volker: can you upload the correct tarball on the mirrors? sorry about the mess...

[jpflori]

comment:16

Follow up for spkg-install at #23604

[vbraun]

comment:17

ok done