New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Extend invariant_generators to the case of Matrix Groups over number fields #2367
Comments
comment:2
The patches (first 2348 then this one) applied cleanly and the above code ran. However, sage -testall failed. Here is one failure:
This would be easy to fix of course but, for the failure I cannot recommend There were other failures,
but they may be unrelated since they were already reported by Jaap Spies |
comment:3
Replying to @wdjoyner:
Clearly the doctest failure in matrix_group_element.py has a trivial fix: The doctest expects output that is incorrect as soon as one switches to an algebraic extension of the rationals:
In gap:
Hence, in general the modified output is needed.
I think so, too. I am about to provide new patches for this ticket and for #2348. |
First apply the patches from #2348, then apply this patch. It extends the method invariant_generators to the case of finite matrix groups over number fields |
comment:5
Attachment: invariant_generators.patch.gz Replying to @wdjoyner:
Now i changed the patches of #2348 and of this ticket. So, a re-check is needed.
These three tests fail on my system as well - with and without the patches. So, it doesn't seem to be related. But with the patches (that partially add further doc tests), the following clearly related tests pass:
|
comment:6
This applies cleanly (first 2348 then this one) to 2.10.3.rc0. It also passes sage -testall (except for the usual 3 that fail, as reported first by Jaap). |
comment:7
This ticket, together with #2348, is now ticket #2395. First reason is that we got a new sage pre-release. Second reason is that my suggestions for fixing the gap interface (#2348) changed. Third reason is that #2348 and this ticket belong closely together, hence, they should be worked on in one ticket. |
This ticket is strongly related with ticket #2348. I fix here a doc test failure that is introduced by the patch from #2348, and the new functionality that i introduce here relies on the patch from #2348.
Problem: Let G be a finite matrix group. So far, G.invariant_generators() worked only if G was defined over the rationals or over GF(prime).
Solution: Singular also provides simple algebraic extensions over these fields, so, it just requires a more careful definition of a singular ring inside the function.
After first applying the patch from #2348 and then applying the new patch, the doc tests of matrix_group.py should pass, and the following should work:
CC: @wdjoyner
Component: group theory
Keywords: invariant ring, matrix group
Issue created by migration from https://trac.sagemath.org/ticket/2367
The text was updated successfully, but these errors were encountered: