Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Minkowski -> minkowski (polyhedra methods) #23685

Closed
videlec opened this issue Aug 23, 2017 · 8 comments
Closed

Minkowski -> minkowski (polyhedra methods) #23685

videlec opened this issue Aug 23, 2017 · 8 comments
Labels
c: geometry p: major / 3 t: bug
Milestone
sage-8.2

Comments

@videlec
Copy link
Contributor

videlec commented Aug 23, 2017

Method names should be lower case... make lower case transition with deprecation for

  • Minkowski_sum
  • Minkowski_difference
  • is_Minkowski_summand
  • Minkowski_decompositions

CC: @mkoeppe @jplab @mo271

Component: geometry

Author: Frédéric Chapoton

Branch/Commit: 6ec20fe

Reviewer: Jean-Philippe Labbé

Issue created by migration from https://trac.sagemath.org/ticket/23685
@videlec videlec added this to the sage-8.1 milestone Aug 23, 2017
@fchapoton
Copy link
Contributor

Branch: u/chapoton/23685

@fchapoton
Copy link
Contributor

Commit: 6ec20fe

@fchapoton
Copy link
Contributor

comment:1

done

New commits:

6ec20fetrac 23685 deprecate methods with capital Minkowski >> minkowski

@fchapoton
Copy link
Contributor

Author: Frédéric Chapoton

@fchapoton fchapoton modified the milestones: sage-8.1, sage-8.2 Jan 5, 2018
@fchapoton
Copy link
Contributor

comment:3

green bot, please review

@jplab
Copy link

jplab commented Jan 6, 2018

comment:4

Looks good to go to me.

@jplab
Copy link

jplab commented Jan 6, 2018

Reviewer: Jean-Philippe Labbé

@vbraun
Copy link
Member

vbraun commented Jan 13, 2018

Changed branch from u/chapoton/23685 to 6ec20fe

@vbraun vbraun closed this as completed in 6591a89 Jan 13, 2018
@jplab jplab mentioned this issue Jun 6, 2020
Closed
@fchapoton fchapoton mentioned this issue Nov 16, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
c: geometry p: major / 3 t: bug
Projects
None yet
Milestone
sage-8.2
Development

No branches or pull requests
4 participants
@vbraun @fchapoton @videlec @jplab