Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove old deprecation warning of Minkowski -> minkowski #27722

Closed
jplab opened this issue Apr 25, 2019 · 12 comments
Closed

Remove old deprecation warning of Minkowski -> minkowski #27722

jplab opened this issue Apr 25, 2019 · 12 comments
Labels
c: geometry p: major / 3 t: enhancement
Milestone
sage-8.8

Comments

@jplab
Copy link

jplab commented Apr 25, 2019

#23685 renamed the minkowski methods. It should now be removed.

CC: @videlec @tscrim

Component: geometry

Keywords: deprecation, polytope

Author: Jean-Philippe Labbé

Branch: 5b9c9ae

Reviewer: Frédéric Chapoton, Travis Scrimshaw

Issue created by migration from https://trac.sagemath.org/ticket/27722
@jplab jplab added this to the sage-8.8 milestone Apr 25, 2019
@jplab
Copy link
Author

jplab commented Apr 25, 2019

Commit: 2ea49f1

@jplab
Copy link
Author

jplab commented Apr 25, 2019

Branch: u/jipilab/27722

@jplab
Copy link
Author

jplab commented Apr 25, 2019

New commits:

589b556Removed old deprecation warnings
2ea49f1removed a forgotten line

@tscrim
Copy link
Collaborator

tscrim commented Apr 25, 2019

comment:2

I think you should squash the two commits together (and you can just force push it) to keep a more clean git history.

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Apr 25, 2019

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

5b9c9aeRemoved old deprecation warnings

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Apr 25, 2019

Changed commit from 2ea49f1 to 5b9c9ae

@jplab
Copy link
Author

jplab commented Apr 25, 2019

comment:4

Done!

@fchapoton
Copy link
Contributor

comment:5

ok, thx

@fchapoton
Copy link
Contributor

Reviewer: Frédéric Chapoton, Travis Scrimshaw

@vbraun
Copy link
Member

vbraun commented Apr 29, 2019

Changed branch from u/jipilab/27722 to 5b9c9ae

@vbraun vbraun closed this as completed in 947b608 Apr 29, 2019
@mkoeppe
Copy link
Member

mkoeppe commented Jun 6, 2020

Changed commit from 5b9c9ae to none

@mkoeppe
Copy link
Member

mkoeppe commented Jun 6, 2020

Changed reviewer from Frédéric Chapoton, Travis Scrimshaw to Frédéric Chapoton, Travis Scrimshaw

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
c: geometry p: major / 3 t: enhancement
Projects
None yet
Milestone
sage-8.8
Development

No branches or pull requests
5 participants
@vbraun @tscrim @fchapoton @jplab @mkoeppe