-
-
Notifications
You must be signed in to change notification settings - Fork 439
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Failure of specialization over some rings #23811
Comments
Branch: u/paulfili/develop |
Changed branch from u/paulfili/develop to none |
Branch: u/paulfili/specialization-fix |
Changed branch from u/paulfili/specialization-fix to u/bhutz/specialization-fix |
Commit: |
Changed author from paulfili to Paul Fili |
Reviewer: Ben Hutz |
comment:6
This fixes the issue. I just made a minor whitespace change. I think this is just a minor priority since Sage is failing with an error message, we just should be able to deal with that case. |
Changed branch from u/bhutz/specialization-fix to u/paulfili/specialization-fix |
comment:8
Fixed a typo where the doc test added referred to the wrong trac #, otherwise unchanged and should be good to go. New commits:
|
Changed branch from u/paulfili/specialization-fix to |
The following code used to fail in the specialization for polynomials over some rings:
should return:
If the base ring of R was QQ, this would work, but if it was RR, it would fail. The problem was in the specialization function, which used a dictionary psi whose keys were supposed to belong to the flattened ring, but instead belonged to the unflattened polynomial ring. Over some rings the built-in coercion functions would fix this while over others they would not. The dictionary psi has been corrected so that the specialization function works as desired.
Component: algebra
Keywords: polynomials, specialization
Author: Paul Fili
Branch/Commit:
5fedbef
Reviewer: Ben Hutz
Issue created by migration from https://trac.sagemath.org/ticket/23811
The text was updated successfully, but these errors were encountered: