Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Failure of specialization over some rings #23811

Closed
pfili opened this issue Sep 8, 2017 · 13 comments
Closed

Failure of specialization over some rings #23811

pfili opened this issue Sep 8, 2017 · 13 comments

Comments

@pfili
Copy link

pfili commented Sep 8, 2017

The following code used to fail in the specialization for polynomials over some rings:

            sage: R.<c>=RR[]
            sage: P.<z>=AffineSpace(R,1)
            sage: H=End(P)
            sage: f=H([z^2+c])
            sage: f.specialization({c:1})

should return:

            Scheme endomorphism of Affine Space of dimension 1 over Real Field with 53 bits of precision
              Defn: Defined on coordinates by sending (z) to
                    (z^2 + 1.00000000000000)

If the base ring of R was QQ, this would work, but if it was RR, it would fail. The problem was in the specialization function, which used a dictionary psi whose keys were supposed to belong to the flattened ring, but instead belonged to the unflattened polynomial ring. Over some rings the built-in coercion functions would fix this while over others they would not. The dictionary psi has been corrected so that the specialization function works as desired.

Component: algebra

Keywords: polynomials, specialization

Author: Paul Fili

Branch/Commit: 5fedbef

Reviewer: Ben Hutz

Issue created by migration from https://trac.sagemath.org/ticket/23811

@pfili pfili added this to the sage-8.1 milestone Sep 8, 2017
@pfili
Copy link
Author

pfili commented Sep 8, 2017

Branch: u/paulfili/develop

@pfili
Copy link
Author

pfili commented Sep 8, 2017

Changed branch from u/paulfili/develop to none

@pfili
Copy link
Author

pfili commented Sep 8, 2017

Branch: u/paulfili/specialization-fix

@bhutz
Copy link

bhutz commented Sep 9, 2017

Changed branch from u/paulfili/specialization-fix to u/bhutz/specialization-fix

@bhutz
Copy link

bhutz commented Sep 9, 2017

New commits:

20e33ebFixed dictionary psi in specialization function
e447f8323811: minor whitespace fix

@bhutz
Copy link

bhutz commented Sep 9, 2017

Commit: e447f83

@bhutz
Copy link

bhutz commented Sep 9, 2017

Changed author from paulfili to Paul Fili

@bhutz
Copy link

bhutz commented Sep 9, 2017

Reviewer: Ben Hutz

@bhutz
Copy link

bhutz commented Sep 9, 2017

comment:6

This fixes the issue. I just made a minor whitespace change.

I think this is just a minor priority since Sage is failing with an error message, we just should be able to deal with that case.

@pfili
Copy link
Author

pfili commented Sep 9, 2017

Changed branch from u/bhutz/specialization-fix to u/paulfili/specialization-fix

@pfili
Copy link
Author

pfili commented Sep 9, 2017

Changed commit from e447f83 to 5fedbef

@pfili
Copy link
Author

pfili commented Sep 9, 2017

comment:8

Fixed a typo where the doc test added referred to the wrong trac #, otherwise unchanged and should be good to go.


New commits:

5fedbefFixed a typo in the doc (referred to the wrong trac #)

@vbraun
Copy link
Member

vbraun commented Sep 24, 2017

Changed branch from u/paulfili/specialization-fix to 5fedbef

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants