New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
disable a very long doctest in omega.py #23865
Comments
Branch: u/vdelecroix/23865 |
New commits:
|
Commit: |
comment:2
Instead of disabling it, could the test be simplified? |
comment:3
This is why I put dkrenn in copy! I am not exactly sure what this doctest is meant for. |
comment:4
Replying to @jdemeyer:
Yes, this can be simplified. I'll provide a corrected version in the next days. |
Replying to @videlec:
The motivation for having this is, that there is a separate computation for the result meaning that the result is somehow verified. I do not recall that it took that long and will investigate. |
comment:6
Thanks Daniel! |
Changed branch from u/vdelecroix/23865 to u/dkrenn/23865 |
Changed author from Vincent Delecroix to Vincent Delecroix, Daniel Krenn |
Reviewer: Daniel Krenn |
comment:9
FYI, all non-long tests in the file now take 1 second; including the long tests 2 seconds. |
Changed author from Vincent Delecroix, Daniel Krenn to Daniel Krenn |
comment:10
Indeed, on the patchbot it is now
Thanks! |
Changed reviewer from Daniel Krenn to Daniel Krenn, Vincent Delecroix |
comment:11
oups. I forgot to positive review it... |
Changed branch from u/dkrenn/23865 to |
Disable the following from
sage/rings/polynomial/omega.py
that takes forever without any justification(running the doctests in
omega.py
takes longer than running the doctests in all other files fromsage/rings/polynomial/
)CC: @dkrenn
Component: documentation
Author: Daniel Krenn
Branch/Commit:
12734e4
Reviewer: Daniel Krenn, Vincent Delecroix
Issue created by migration from https://trac.sagemath.org/ticket/23865
The text was updated successfully, but these errors were encountered: