Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade R to 3.4.3 #24306

Closed
EmmanuelCharpentier mannequin opened this issue Nov 30, 2017 · 12 comments
Closed

Upgrade R to 3.4.3 #24306

EmmanuelCharpentier mannequin opened this issue Nov 30, 2017 · 12 comments

Comments

@EmmanuelCharpentier
Copy link
Mannequin

EmmanuelCharpentier mannequin commented Nov 30, 2017

Usual reasons...

Upstream tarball : https://cran.r-project.org/src/base/R-3/R-3.4.3.tar.gz

Note to testers : this depends on already merged #24240 - no need to worry about it.

Depends on #24240

Component: packages: standard

Author: Emmanuel Charpentier

Branch/Commit: 42c8599

Reviewer: Dima Pasechnik

Issue created by migration from https://trac.sagemath.org/ticket/24306

@EmmanuelCharpentier EmmanuelCharpentier mannequin added this to the sage-8.1 milestone Nov 30, 2017
@EmmanuelCharpentier

This comment has been minimized.

@EmmanuelCharpentier
Copy link
Mannequin Author

EmmanuelCharpentier mannequin commented Nov 30, 2017

Branch: u/charpent/upgrade_r_to_3_4_3

@EmmanuelCharpentier
Copy link
Mannequin Author

EmmanuelCharpentier mannequin commented Nov 30, 2017

comment:3

On top of 8.0.rc3 + #24240, this :

  • builds and passes {{{ptestlong without any error whatsoever ;
  • sort-of passes its own test suite, modulo expected failures and numerical noise (but see this post on sage-devel) ;
  • installs my 443 R packages without problem.

==needs_review. As usual, rewiew on Cygwin and Macintosh more than welcome...

Note : upgading r entails upgrading rpy2 : this is normal.


New commits:

7cde14224240 : Updated freetype to 2.8.1.
31aa9fbMerge branch 'u/charpent/fix_R_graphics_again' of trac.sagemath.org:sage into t/24306/upgrade_r_to_3_4_3
42c859924306 : upstreap source, updated package version and checksum.

@EmmanuelCharpentier
Copy link
Mannequin Author

EmmanuelCharpentier mannequin commented Nov 30, 2017

Commit: 42c8599

@EmmanuelCharpentier
Copy link
Mannequin Author

EmmanuelCharpentier mannequin commented Dec 7, 2017

comment:4

Wups ! Forgot to set my name as author...

@EmmanuelCharpentier
Copy link
Mannequin Author

EmmanuelCharpentier mannequin commented Dec 7, 2017

Author: Emmanuel Charpentier

@dimpase

This comment has been minimized.

@dimpase
Copy link
Member

dimpase commented Dec 29, 2017

comment:6

looks good on Linux, I'll test on OSX later...

@dimpase
Copy link
Member

dimpase commented Dec 30, 2017

comment:7

OK, looks good to me.

@dimpase
Copy link
Member

dimpase commented Dec 30, 2017

Reviewer: Dima Pasechnik

@EmmanuelCharpentier
Copy link
Mannequin Author

EmmanuelCharpentier mannequin commented Dec 31, 2017

comment:8

Thank you, Dimitri !

For the record : I've checked it myself on Cygwin (VM running Windows 10).

@vbraun
Copy link
Member

vbraun commented Jan 1, 2018

Changed branch from u/charpent/upgrade_r_to_3_4_3 to 42c8599

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants