-
-
Notifications
You must be signed in to change notification settings - Fork 459
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade freetype to 2.8.1. #24240
Comments
comment:1
"has no graphics capabilities" is pretty vague. What do you consider to be the bug precisely? |
Branch: u/charpent/fix_R_graphics_again |
Branch pushed to git repo; I updated commit sha1. New commits:
|
Commit: |
comment:4
Replying to @jdemeyer:
Precisely what it means : This might been due to recent changes in system's X11 (Debian now uses Wayland by default), which might have triggered an hitherto unknown bug. It turns out that updating The resulting Sage passes ptestlong without any error whatsoever ; R sirt-of-passing its own test suite as usual. ==> |
Author: Emmanuel Charpentier |
This comment has been minimized.
This comment has been minimized.
comment:5
Shouldn't this be a blocker for 8.1? |
comment:6
Replying to @novoselt:
It should. I considered it. But I doubt somehow that this opinion would be shared by the core developers, given the popularity of R among them... Anyway, feel free to review my patch ;-). |
comment:7
Well, the patch works in terms of upgrading freetype, but on Debian Stretch I don't see the problem before or after. So I can give positive review to a ticket titled "Upgrade freetype". |
comment:8
Replying to @novoselt:
Do you run Xorg or Wayland ? I'm running testing, where X11 defaults to Wayland : that might be the source of the diffeernces in vbehaviour. Can you plot from a terminal running "sage -R" ? For example, try "curve(sin(x), -pi, pi)". Using graphics in the R librar interface from Sage is a bit more intricate. More on this later... |
This comment has been minimized.
This comment has been minimized.
comment:10
Replying to @EmmanuelCharpentier:
I am on stable, so presumably Xorg.
I can as in it does not cause errors and there is a PDF file created with a plot. I am far from being an expert on the topic - my only interest in R graphics is to make sure that it keeps working for SageMathCell. |
Reviewer: Andrey Novoseltsev |
comment:11
Resetting to |
comment:12
How is it supposed to test this ticket that needs a new package placed into |
comment:13
Replying to @novoselt:
Download the tarball linked in the description and place it into Edit: Oh, you mean the patchbots. I have heard that they are supposed to do this somehow, but I don't know if that's true. |
comment:14
Yes, I was curious how patchbot is supposed to guess it, although perhaps it reads the description and understands it sufficiently. |
comment:15
Replying to @jhpalmieri:
Apparently, one of them did early this morning. But it seems to have just patched the sources (successfully), but didn't try to rebuild Sage. |
comment:16
Okay. This one has been (positively) checked by 5 patchbots (while none of them did much : this is considered as an SPKG). I revert to the positive review given by Andrey Novoseltsev . |
Changed branch from u/charpent/fix_R_graphics_again to |
[ Title modified at
novoselt
's suggestion ] :Motivation : in Sage 8.1.rc2, R can't plot (at least on Debian testing, whose X is Wayland by default) :
Contrast with the system's R :
The fix is to upgrade
freetype
to 2.8.1. Upstream tarball is : https://download.savannah.gnu.org/releases/freetype/freetype-2.8.1.tar.bz2Component: packages: standard
Keywords: r-project graphics interfaces
Author: Emmanuel Charpentier
Branch/Commit:
7cde142
Reviewer: Andrey Novoseltsev
Issue created by migration from https://trac.sagemath.org/ticket/24240
The text was updated successfully, but these errors were encountered: