Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use new-style GlobalOptions #24322

Closed
jdemeyer opened this issue Dec 4, 2017 · 11 comments
Closed

Use new-style GlobalOptions #24322

jdemeyer opened this issue Dec 4, 2017 · 11 comments
Labels
p: major / 3 t: enhancement t: tests
Milestone
sage-8.2

Comments

@jdemeyer
Copy link

jdemeyer commented Dec 4, 2017

The syntax

options=GlobalOptions(...
    doc="""
    EXAMPLES::

        sage: #doctest here
    """
)

has the unfortunate effect that the doctests are not actually seen as doctests. They are just a string, nothing more. Ticket #23238 was created to allow a new syntax for GlobalOptions, which makes the doctests actually doctests.

This ticket uses the new syntax in all cases. This enables some doctests which were not tested before. As expected, this uncovered various failures. Some trivial ones are fixed, others are marked as # known bug with the following tickets opened: #24323, #24324, #24325. #24326

CC: @AndrewAtLarge @tscrim

Component: doctest coverage

Author: Jeroen Demeyer

Branch/Commit: 577504b

Reviewer: Travis Scrimshaw

Issue created by migration from https://trac.sagemath.org/ticket/24322
@jdemeyer jdemeyer added this to the sage-8.2 milestone Dec 4, 2017
@jdemeyer

This comment has been minimized.

Sign in to view
@jdemeyer jdemeyer changed the title Use new-style GlobalOptions in combinat Use new-style GlobalOptions to test examples Dec 4, 2017
@jdemeyer

This comment has been minimized.

Sign in to view
@jdemeyer jdemeyer changed the title Use new-style GlobalOptions to test examples Use new-style GlobalOptions Dec 4, 2017
@jdemeyer

This comment has been minimized.

Sign in to view
@jdemeyer

This comment has been minimized.

Sign in to view
@jdemeyer
Copy link
Author

jdemeyer commented Dec 4, 2017

Branch: u/jdemeyer/use_new_style_globaloptions_in_combinat

@jdemeyer
Copy link
Author

jdemeyer commented Dec 4, 2017

Commit: 577504b

@jdemeyer
Copy link
Author

jdemeyer commented Dec 4, 2017

New commits:

577504bUse new-style GlobalOptions to test examples

@jdemeyer

This comment has been minimized.

Sign in to view
@tscrim
Copy link
Collaborator

tscrim commented Dec 6, 2017

comment:8

Now to fix all of those follow-up tickets. :)

@tscrim
Copy link
Collaborator

tscrim commented Dec 6, 2017

Reviewer: Travis Scrimshaw

@vbraun
Copy link
Member

vbraun commented Dec 13, 2017

Changed branch from u/jdemeyer/use_new_style_globaloptions_in_combinat to 577504b

@vbraun vbraun closed this as completed in 2cbaa17 Dec 13, 2017
This was referenced May 8, 2018
Closed
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
p: major / 3 t: enhancement t: tests
Projects
None yet
Milestone
sage-8.2
Development

No branches or pull requests
3 participants
@vbraun @tscrim @jdemeyer