TamariIntervalPosets: failing tests in options

[jdemeyer]

When the untested examples in src/sage/combinat/interval_posets.py involving GlobalOptions are actually tested:

sage -t --long src/sage/combinat/interval_posets.py
**********************************************************************
File "src/sage/combinat/interval_posets.py", line 2468, in sage.combinat.interval_posets.TamariIntervalPosets.options
Failed example:
    ip.latex_options.color_decreasing
Exception raised:
    Traceback (most recent call last):
      File "/usr/local/src/sage-config/local/lib/python2.7/site-packages/sage/doctest/forker.py", line 515, in _run
        self.compile_and_execute(example, compiler, test.globs)
      File "/usr/local/src/sage-config/local/lib/python2.7/site-packages/sage/doctest/forker.py", line 885, in compile_and_execute
        exec(compiled, globs)
      File "<doctest sage.combinat.interval_posets.TamariIntervalPosets.options[1]>", line 1, in <module>
        ip.latex_options.color_decreasing
    AttributeError: 'function' object has no attribute 'color_decreasing'
**********************************************************************
File "src/sage/combinat/interval_posets.py", line 2471, in sage.combinat.interval_posets.TamariIntervalPosets.options
Failed example:
    ip.latex_options.color_decreasing
Exception raised:
    Traceback (most recent call last):
      File "/usr/local/src/sage-config/local/lib/python2.7/site-packages/sage/doctest/forker.py", line 515, in _run
        self.compile_and_execute(example, compiler, test.globs)
      File "/usr/local/src/sage-config/local/lib/python2.7/site-packages/sage/doctest/forker.py", line 885, in compile_and_execute
        exec(compiled, globs)
      File "<doctest sage.combinat.interval_posets.TamariIntervalPosets.options[3]>", line 1, in <module>
        ip.latex_options.color_decreasing
    AttributeError: 'function' object has no attribute 'color_decreasing'
**********************************************************************
File "src/sage/combinat/interval_posets.py", line 2474, in sage.combinat.interval_posets.TamariIntervalPosets.options
Failed example:
    ip.latex_options.color_decreasing
Exception raised:
    Traceback (most recent call last):
      File "/usr/local/src/sage-config/local/lib/python2.7/site-packages/sage/doctest/forker.py", line 515, in _run
        self.compile_and_execute(example, compiler, test.globs)
      File "/usr/local/src/sage-config/local/lib/python2.7/site-packages/sage/doctest/forker.py", line 885, in compile_and_execute
        exec(compiled, globs)
      File "<doctest sage.combinat.interval_posets.TamariIntervalPosets.options[5]>", line 1, in <module>
        ip.latex_options.color_decreasing
    AttributeError: 'function' object has no attribute 'color_decreasing'
**********************************************************************

Depends on #24322

CC: @sagetrac-sage-combinat @fchapoton @darijgr @VivianePons

Component: combinatorics

Author: Frédéric Chapoton

Branch/Commit: 305b769

Reviewer: Travis Scrimshaw

Issue created by migration from https://trac.sagemath.org/ticket/24326

[jdemeyer]

Changed dependencies from #24323 to #24322

[darijgr]

comment:3

This is just the doctests being wrong, right? ip.latex_options.color_decreasing should be ip.latex_options()["color_decreasing"]? Which is also doctested in the set_latex_options doc. So I guess we can remove the broken doctests?

[tscrim]

comment:4

Not quite, the latex_options() method returns the current latex options for that specific ip, whereas the global options are setting the defaults. I think they should become ip.options.color_decreasing (but I haven't checked yet). They definitely should not be removed.

Note that some of them are indirectly tested in set_latex_options in order to show the default vs specific behavior, but the doctests for the global options is also showing how to use the global options too. So also on that basis I say they should not be removed.

[fchapoton]

Branch: u/chapoton/24326

[fchapoton]

Commit: 305b769

[fchapoton]

comment:5

please review

---

New commits:

305b769

trac 24326 fixing options doctests in Tamari Intervals

[fchapoton]

Author: Frédéric Chapoton

[fchapoton]

comment:6

green bot

[tscrim]

Reviewer: Travis Scrimshaw

[vbraun]

Changed branch from u/chapoton/24326 to 305b769