Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dancing links random failures #24424

Closed
vbraun opened this issue Dec 23, 2017 · 7 comments
Closed

Dancing links random failures #24424

vbraun opened this issue Dec 23, 2017 · 7 comments

Comments

@vbraun
Copy link
Member

vbraun commented Dec 23, 2017

The output of one_solution is random:

**********************************************************************
File "src/sage/combinat/matrices/dancing_links.pyx", line 27, in sage.combinat.matrices.dancing_links
Failed example:
    sorted(x.one_solution(ncpus=8))
Expected:
    [0, 1]
Got:
    [2, 3]
**********************************************************************
1 item had failures:
   1 of  20 in sage.combinat.matrices.dancing_links
    [175 tests, 1 failure, 8.38 s]
----------------------------------------------------------------------
sage -t --long src/sage/combinat/matrices/dancing_links.pyx  # 1 doctest failed
----------------------------------------------------------------------

Also, does ncpus=8 really use 8 cores? We already parallelize doctests! Tests should definitely not x8 that.

CC: @seblabbe @videlec

Component: combinatorics

Keywords: random_fail

Author: Sébastien Labbé

Branch/Commit: 2df8c97

Reviewer: Volker Braun

Issue created by migration from https://trac.sagemath.org/ticket/24424

@vbraun vbraun added this to the sage-8.2 milestone Dec 23, 2017
@seblabbe
Copy link
Contributor

Commit: 2df8c97

@seblabbe
Copy link
Contributor

Branch: u/slabbe/24424

@seblabbe
Copy link
Contributor

New commits:

2df8c9724424: fixing random doctests failures

@seblabbe
Copy link
Contributor

Replying to @vbraun:

Also, does ncpus=8 really use 8 cores? We already parallelize doctests! Tests should definitely not x8 that.

I changed 8 to 2. The dancing links problem in question uses only 6 rows. So, it is not something that will use a lot of cpu time (something like 1ms).

@vbraun
Copy link
Member Author

vbraun commented Dec 24, 2017

Reviewer: Volker Braun

@vbraun
Copy link
Member Author

vbraun commented Dec 24, 2017

Author: Sébastien Labbé

@vbraun
Copy link
Member Author

vbraun commented Dec 25, 2017

Changed branch from u/slabbe/24424 to 2df8c97

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants