Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support downloading of symlinked tarballs #24476

Closed
jdemeyer opened this issue Jan 5, 2018 · 12 comments
Closed

Support downloading of symlinked tarballs #24476

jdemeyer opened this issue Jan 5, 2018 · 12 comments

Comments

@jdemeyer
Copy link

jdemeyer commented Jan 5, 2018

#12426 introduces a new package "gfortran" which reuses the gcc tarball. This is done by symlinking various files in build/pkgs/gfortran to build/pkgs/gcc. This confuses the tarball downloader, so we add support for such symlinks in sage_bootstrap.

CC: @embray @vbraun @kiwifb

Component: build

Author: Jeroen Demeyer

Branch/Commit: 5b8e8dd

Reviewer: Dima Pasechnik

Issue created by migration from https://trac.sagemath.org/ticket/24476

@jdemeyer jdemeyer added this to the sage-8.2 milestone Jan 5, 2018
@jdemeyer jdemeyer changed the title Properly download symlinked tarballs Support downloading of symlinked tarballs Jan 5, 2018
@jdemeyer
Copy link
Author

jdemeyer commented Jan 5, 2018

@jdemeyer
Copy link
Author

jdemeyer commented Jan 5, 2018

New commits:

5b8e8ddSupport downloading of symlinked tarballs

@jdemeyer
Copy link
Author

jdemeyer commented Jan 5, 2018

Commit: 5b8e8dd

@jdemeyer

This comment has been minimized.

@vbraun
Copy link
Member

vbraun commented Jan 5, 2018

comment:7

So whats the plan, have a symlinked tarball or two packages refer to the same tarball? The latter seems more sane to me. Whereas the former raises some questions, e.g. what to upload to mirrors.

Looking up tarball name -> package name isn't really important I think. Could just return a set of matching packages.

@kiwifb
Copy link
Member

kiwifb commented Jan 5, 2018

comment:8

Two packages referring to the same tarball. In #12426 I ended up creating a spkg for gfortran which of course uses gcc's tarball.

@jdemeyer
Copy link
Author

jdemeyer commented Jan 6, 2018

comment:9

Replying to @vbraun:

Looking up tarball name -> package name isn't really important I think.

It is needed because the tarballs on the server are stored per package. The URL is something like .../spkg/upstream/gcc/gcc-7.2.0.xz, where gcc is the package name.

@dimpase
Copy link
Member

dimpase commented Jan 8, 2018

comment:10

I am testing this together with #12426. If this is the only scenario to consider, this looks good. Should then #12426 become a dependence here?

@jdemeyer
Copy link
Author

jdemeyer commented Jan 8, 2018

comment:11

Replying to @dimpase:

Should then #12426 become a dependence here?

No. Why should it be?

@dimpase
Copy link
Member

dimpase commented Jan 12, 2018

comment:12

looks good to me.

@dimpase
Copy link
Member

dimpase commented Jan 12, 2018

Reviewer: Dima Pasechnik

@vbraun
Copy link
Member

vbraun commented Jan 14, 2018

Changed branch from u/jdemeyer/support_downloading_of_symlinked_tarballs to 5b8e8dd

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants