Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Run doctests in CI #24854

Closed
saraedum opened this issue Feb 27, 2018 · 136 comments
Closed

Run doctests in CI #24854

saraedum opened this issue Feb 27, 2018 · 136 comments
Labels
c: build c: docker p: minor / 4 t: enhancement

Comments

@saraedum
Copy link
Member

This ticket proposes to run the doctests on GitLab.

On GitLab, I would like to run the --new and --short doctests and if these pass also run the --long ones (Without explicit confirmation, as it is easier to get additional runners on GitLab CI.)

Trac macro Image(https://gitlab.com/sagemath/dev/trac/badges/u/saraedum/24854/pipeline.svg,link=https://gitlab.com/sagemath/dev/trac/commits/u/saraedum/24854)

CC: @embray @nthiery @roed314

Component: build

Keywords: ContinuousIntegration

Author: Julian Rüth

Branch/Commit: u/mkoeppe/24854 @ 24e292c

Issue created by migration from https://trac.sagemath.org/ticket/24854
@saraedum saraedum added this to the sage-8.2 milestone Feb 27, 2018
@saraedum
Copy link
Member Author

comment:1

There were some issues with building the documentation (namely building the German "A Tour of Sage".) Apparently some package is missing, see cschwan/sage-on-gentoo#338 (comment).

@saraedum
Copy link
Member Author

Branch: u/saraedum/doctest-ci

@saraedum
Copy link
Member Author

Author: Julian Rüth

@saraedum
Copy link
Member Author

Commit: 348ae21

@saraedum

This comment has been minimized.

Sign in to view
@saraedum
Copy link
Member Author

Last 10 new commits:

be3a0f7The docbuild crashes happen during an os.fork to spawn tachyon
7d85dc7Something related to the sphinxbuild seems to be leaking memory
50898feTry to build-from-scratch on GitLab's underpowered CI machines
95c6275Comment on fork logic in docbuilding
c0574caMerge remote-tracking branch 'trac/develop' into u/saraedum/gitlabci
329fdabfix tags for build-from-latest
048e2d8silence unicode warnings from the patchbot
f9c772eFix filtering logic in sphinx logger
f043163Fixed some minor doctest issues
348ae21Run (--long) doctests as part of CI

@saraedum

This comment has been minimized.

Sign in to view
@saraedum

This comment has been minimized.

Sign in to view
@embray
Copy link
Contributor

embray commented Apr 29, 2018

comment:6

One thing Sage desperately needs is a "short" test suite for quick smoke tests--maybe not achieving quite as high coverage but still a lot.

Actually what we really need is better (any) coverage analysis. That's something that's been high on my TODO list (among other things high on that list), and is probably a bit challenging to get working right.

@saraedum

This comment has been minimized.

Sign in to view
@saraedum

This comment has been minimized.

Sign in to view
@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Apr 30, 2018

Branch pushed to git repo; I updated commit sha1. Last 10 new commits:

b707ff2fix typo in CI
360179cmake pull-dockerhub.sh +x to work on CircleCI
9dc5290Fix docker images for doctest CI
d8daefdfix typo
5948288Run long doctests whenever non-long doctests have passed
d73c283RAM should define the limit when deciding how much parallelity we can handle
6cf3623Do not overcommit so much on CPU
f459bc3Revert "Do not overcommit so much on CPU"
2e553c7Revert "Revert "Do not overcommit so much on CPU""
7de6efeAdd optional: doc for tests that need a built HTML documentation

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Apr 30, 2018

Changed commit from 348ae21 to 7de6efe

@saraedum

This comment has been minimized.

Sign in to view
@saraedum
Copy link
Member Author

saraedum commented May 1, 2018

Changed dependencies from #24655 to #24655, #25270

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented May 1, 2018

Branch pushed to git repo; I updated commit sha1. New commits:

bdf5ee2Run doctests three times
94dfbeeput | on the right line for the spawned shell to understand continuation
5ac5c9aActually run --long doctests

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented May 1, 2018

Changed commit from 7de6efe to 5ac5c9a

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented May 1, 2018

Changed commit from 5ac5c9a to f574976

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented May 1, 2018

Branch pushed to git repo; I updated commit sha1. New commits:

7514796Run --new doctests to get faster failures
f574976Run only short doctests on CirlceCI at first

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented May 1, 2018

Branch pushed to git repo; I updated commit sha1. New commits:

3d45a81Fix short doctest runner

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented May 1, 2018

Changed commit from f574976 to 3d45a81

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented May 1, 2018

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

0ffd0a1Fix short doctest runner

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented May 1, 2018

Changed commit from 3d45a81 to 0ffd0a1

@saraedum

This comment has been minimized.

Sign in to view
@saraedum
Copy link
Member Author

Changed commit from 0ffd0a1 to none

@saraedum
Copy link
Member Author

Changed branch from u/saraedum/doctest-ci to none

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Sep 2, 2018

Changed commit from 42cd86a to 6fe9d1d

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Sep 2, 2018

Changed commit from 6fe9d1d to 81cb1b4

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Sep 2, 2018

Branch pushed to git repo; I updated commit sha1. New commits:

81cb1b4Explain that some tests failed

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Sep 2, 2018

Changed commit from 81cb1b4 to 0016222

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Sep 2, 2018

Branch pushed to git repo; I updated commit sha1. New commits:

0016222pipefail to make head-tail work

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Oct 24, 2018

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

9b3cc0fRun doctests in CI

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Oct 24, 2018

Changed commit from 0016222 to 9b3cc0f

@saraedum
Copy link
Member Author

Changed work issues from squash commit history to none

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Nov 13, 2018

Changed commit from 9b3cc0f to 86c452e

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Nov 13, 2018

Branch pushed to git repo; I updated commit sha1. New commits:

86c452eMerge remote-tracking branch 'trac/develop' into 24854

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Nov 25, 2018

Changed commit from 86c452e to b8fe26a

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Nov 25, 2018

Branch pushed to git repo; I updated commit sha1. New commits:

b8fe26aMerge remote-tracking branch 'trac/develop' into 24854

@saraedum
Copy link
Member Author

New commits:

b8fe26aMerge remote-tracking branch 'trac/develop' into 24854

@saraedum
Copy link
Member Author

Changed dependencies from #24655, #25270, #25431 to #24655, #25270, #25431, #26732

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Sep 13, 2019

Branch pushed to git repo; I updated commit sha1. This was a forced push. Last 10 new commits:

6619e31Limit docker build output
497077dMerge latest beta into docker-py3
155e3acBuild docker in parallel
7c9ea55Build docker in parallel
d36ffe1Push Python 3 docker images to *-py3
a229ffcUndo docker changes
22da087do not remove config.status from dev image
c3d9c14Keep misc-clean around longer in Makefile
5431987Merge remote-tracking branch 'trac/develop' into 28041
e6b287bMerge remote-tracking branch 'trac/u/saraedum/mrs/22/docker-python3' into u/saraedum/24854

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Sep 13, 2019

Changed commit from b8fe26a to e6b287b

@saraedum

This comment has been minimized.

Sign in to view
@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Sep 13, 2019

Changed commit from e6b287b to 8495bd0

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Sep 13, 2019

Branch pushed to git repo; I updated commit sha1. New commits:

8495bd0Remove remnants of CircleCI support

@saraedum
Copy link
Member Author

Changed dependencies from #24655, #25270, #25431, #26732 to #24655, #25270, #25431, #26732, #28041

@saraedum
Copy link
Member Author

Changed keywords from CI to ContinuousIntegration

@mkoeppe
Copy link
Member

mkoeppe commented Sep 11, 2020

Changed branch from u/saraedum/24854 to u/mkoeppe/24854

@mkoeppe
Copy link
Member

mkoeppe commented Sep 11, 2020

comment:80

Rebased, just to see what changes are on this old branch

New commits:

24e292cRun doctests in CI (squash of 24854)

@mkoeppe
Copy link
Member

mkoeppe commented Sep 11, 2020

Changed dependencies from #24655, #25270, #25431, #26732, #28041 to none

@mkoeppe
Copy link
Member

mkoeppe commented Sep 11, 2020

Changed commit from 8495bd0 to 24e292c

@mkoeppe mkoeppe removed this from the sage-8.2 milestone Dec 29, 2022
This was referenced Oct 7, 2019
Closed
Closed
@tobiasdiez
Copy link
Contributor

Doctests are run on every push in PRs now, so this seems to be no longer required.

@tobiasdiez tobiasdiez closed this as not planned Won't fix, can't repro, duplicate, stale Feb 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
c: build c: docker p: minor / 4 t: enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@saraedum @embray @timokau @tobiasdiez @mkoeppe