-
-
Notifications
You must be signed in to change notification settings - Fork 452
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement rank for sparse integer matrix using LinBox #25257
Comments
comment:1
Here is an initial branch that is horribly hacked together, but it was sufficient for my purposes and to demonstrate that we should do this. New commits:
|
This comment has been minimized.
This comment has been minimized.
Commit: |
comment:2
Nice. Please add tests for all possible corner cases (0 x 1, 1 x 0 and 0 x 0). I had troubles with these with other linbox functions. I think that it would be better to isolate the conversion |
comment:3
BTW, I already have rank/det/solve for sparse matrices on a branch. You might want to wait for next week (Sage days in Cernay). |
comment:4
(my version has C++ conversions between the |
comment:5
But priority is #24544 which fails to compile :-( |
comment:6
I completely agree with comment:2. I was just trying to get the rank of certain big matrices rather than do rank frequently, so converting from the internal format was not a big issue for me. Again "horribly hacked together" I am happy to wait until next week. I will be visiting Sydney, so I probably won't have much time to devote to Sage development next week. However, I am happy to review tickets where I can. |
comment:7
Could you try #23214? |
Changed author from Travis Scrimshaw to none |
Changed commit from |
Changed branch from public/linear_algebra/linbox_rank_sparse_matrix-25257 to none |
comment:8
I would say #23214 superseeds this, which we can close as a duplicate. |
comment:9
Thanks for creating this ticket: it motivated me to finish #23214. |
Reviewer: Vincent Delecroix |
comment:11
closing positively reviewed duplicates |
Right now the only way to compute the rank of a sparse integer matrix is to either convert it to a dense matrix or a rational matrix (which simply does Gaussian elimination). Both of these options are horrible. Linbox provides a rank algorithm more for sparse matrices. The aim of this ticket is to expose this.
For example, I have a sparse matrix
it takes <11s with linbox on my computer, and I gave up after well over minute doing it over Q.
This is a part of #13915.
CC: @sagetrac-Bouillaguet @ClementPernet @videlec
Component: linear algebra
Keywords: linbox, sparse matrix
Reviewer: Vincent Delecroix
Issue created by migration from https://trac.sagemath.org/ticket/25257
The text was updated successfully, but these errors were encountered: