Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement _an_element_ for matrix spaces #25504

Closed
jdemeyer opened this issue Jun 4, 2018 · 15 comments
Closed

Implement _an_element_ for matrix spaces #25504

jdemeyer opened this issue Jun 4, 2018 · 15 comments

Comments

@jdemeyer
Copy link

jdemeyer commented Jun 4, 2018

Currently, this is a bit too trivial:

sage: MatrixSpace(QQ, 3, 3).an_element()
[1 0 0]
[0 0 0]
[0 0 0]

CC: @videlec

Component: linear algebra

Author: Jeroen Demeyer

Branch/Commit: 779dffb

Reviewer: Travis Scrimshaw

Issue created by migration from https://trac.sagemath.org/ticket/25504

@jdemeyer jdemeyer added this to the sage-8.3 milestone Jun 4, 2018
@jdemeyer
Copy link
Author

jdemeyer commented Jun 4, 2018

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jun 4, 2018

Commit: ac7cf06

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jun 4, 2018

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

ac7cf06Implement `_an_element_` for matrix spaces

@jdemeyer
Copy link
Author

jdemeyer commented Jun 4, 2018

comment:4

See patchbot

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jun 5, 2018

Branch pushed to git repo; I updated commit sha1. New commits:

2c09211Doctest fixes

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jun 5, 2018

Changed commit from ac7cf06 to 2c09211

@tscrim
Copy link
Collaborator

tscrim commented Jun 6, 2018

comment:7

If you could add a test M.density() for the sparse test to verify that it is indeed sparse (beyond the implicit test that you would kill your memory if such a sparse matrix was dense). Actually, that test makes me a bit nervous if at some point it does turn into a dense matrix. It would make it nearly impossible to debug because my computer would keep running out of memory. Perhaps it would be better to scale down the matrix and just do M.density() to show it is sparse.

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jun 6, 2018

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

e09aed6Implement `_an_element_` for matrix spaces

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jun 6, 2018

Changed commit from 2c09211 to e09aed6

@jdemeyer
Copy link
Author

jdemeyer commented Jun 6, 2018

comment:9

I updated the branch.

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jun 6, 2018

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

779dffbImplement `_an_element_` for matrix spaces

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jun 6, 2018

Changed commit from e09aed6 to 779dffb

@tscrim
Copy link
Collaborator

tscrim commented Jun 6, 2018

comment:11

Thank you. LGTM.

@tscrim
Copy link
Collaborator

tscrim commented Jun 6, 2018

Reviewer: Travis Scrimshaw

@vbraun
Copy link
Member

vbraun commented Jun 7, 2018

Changed branch from u/jdemeyer/implement__an_element__for_matrix_spaces to 779dffb

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants