Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move matrices to new coercion model #23719

Closed
videlec opened this issue Aug 25, 2017 · 62 comments
Closed

Move matrices to new coercion model #23719

videlec opened this issue Aug 25, 2017 · 62 comments

Comments

@videlec
Copy link
Contributor

videlec commented Aug 25, 2017

MatrixSpace do not play well with the category framework. One step forward is to rename the attribute _matrix_class to Element so that it will have element_class pointing to the element class generated via Parent.__init__.

Related tickets: #19669

Depends on #25504
Depends on #25505
Depends on #25542
Depends on #25554
Depends on #25555

CC: @tscrim

Component: coercion

Keywords: days94

Author: Jeroen Demeyer

Branch/Commit: b03b8bf

Reviewer: Travis Scrimshaw

Issue created by migration from https://trac.sagemath.org/ticket/23719

@videlec videlec added this to the sage-8.1 milestone Aug 25, 2017
@videlec

This comment has been minimized.

@jdemeyer
Copy link

Changed dependencies from #23706 to #24742

@jdemeyer jdemeyer changed the title MatrixSpace: replace _matrix_class with element_class Move matrices to new coercion model Feb 15, 2018
@tscrim

This comment has been minimized.

@tscrim tscrim modified the milestones: sage-8.1, sage-8.2 Feb 15, 2018
@jdemeyer
Copy link

jdemeyer commented Mar 8, 2018

comment:4

If you want progress on this, it would be good to review #24742.

@jdemeyer

This comment has been minimized.

@jdemeyer
Copy link

Changed dependencies from #24742 to none

@jdemeyer jdemeyer modified the milestones: sage-8.2, sage-8.3 May 26, 2018
@jdemeyer
Copy link

jdemeyer commented Jun 4, 2018

Author: Jeroen Demeyer

@jdemeyer
Copy link

jdemeyer commented Jun 4, 2018

comment:7

Working on this...

@jdemeyer
Copy link

jdemeyer commented Jun 4, 2018

comment:8

Vincent, since you created this ticket: are there any concrete issues that would be fixed by this?

@videlec
Copy link
Contributor Author

videlec commented Jun 4, 2018

comment:9

My aim was to allow matrices on semi-rings (ie structure having + and * but not necessarily - and /). We are far away from there though. So only a wishlist.

@jdemeyer
Copy link

jdemeyer commented Jun 4, 2018

comment:10

Replying to @videlec:

My aim was to allow matrices on semi-rings

What do you mean with "allow"? And how would that be related to changing element_class?

@jdemeyer
Copy link

jdemeyer commented Jun 4, 2018

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jun 4, 2018

Commit: e48d153

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jun 4, 2018

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

ac7cf06Implement `_an_element_` for matrix spaces
e48d153Move matrices to new coercion model

@jdemeyer
Copy link

jdemeyer commented Jun 4, 2018

Dependencies: #25504

@jdemeyer
Copy link

jdemeyer commented Jun 7, 2018

Changed dependencies from #25504 to #25504, #25505

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jun 8, 2018

Branch pushed to git repo; I updated commit sha1. This was a forced push. Last 10 new commits:

3c4a06dEnable _mul_long for matrices
1eaed37More stuff in the meataxe interface, and a meataxe helper function
8a06c0fFix docstring formatting
13da208Clean up creating Matrix_gfpn_dense matrices
cb52ee3Mark one doctest optional
c8fa7bbClean up `__cinit__` methods of matrices
779dffbImplement `_an_element_` for matrix spaces
6b8517fMerge commit '779dffbbb514290400d2b164b80ddb1a6c8ba04e' into t/23719/move_matrices_to_new_coercion_model
55568c8Misc matrix fixes
c646dc2Move matrices to new coercion model

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jun 8, 2018

Changed commit from e48d153 to c646dc2

@jdemeyer
Copy link

jdemeyer commented Jun 8, 2018

Changed dependencies from #25504, #25505 to #25504, #25505, #25542

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jul 26, 2018

Changed commit from 4b83f2f to ecfb511

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jul 26, 2018

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

ae560ceAdd option to control GC during doctests
ecfb511Move matrices to new coercion model

@jdemeyer
Copy link

comment:42

The error seems unrelated to this ticket. Somebody also got it because of the Singular upgrade, see #25969.

@jdemeyer
Copy link

Changed dependencies from #25504, #25505, #25542, #25554, #25555, #25871 to #25504, #25505, #25542, #25554, #25555, #25969

@videlec
Copy link
Contributor Author

videlec commented Aug 3, 2018

comment:44

update milestone 8.3 -> 8.4

@videlec videlec modified the milestones: sage-8.3, sage-8.4 Aug 3, 2018
@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Aug 16, 2018

Branch pushed to git repo; I updated commit sha1 and set ticket back to needs_review. This was a forced push. New commits:

b03b8bfMove matrices to new coercion model

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Aug 16, 2018

Changed commit from ecfb511 to b03b8bf

@tscrim
Copy link
Collaborator

tscrim commented Aug 16, 2018

comment:46

Is #25969 still a dependency? It seems from the comments like #25969 is not coming from this ticket.

@jdemeyer
Copy link

comment:47

Replying to @tscrim:

Is #25969 still a dependency?

I don't know. We can test again whether the problem magically went away.

@jdemeyer
Copy link

comment:48

Replying to @tscrim:

It seems from the comments like #25969 is not coming from this ticket.

Well, define "coming from". The problem is certainly unrelated and not directly caused by this ticket, but merging this ticket did cause #25969 to appear.

@jdemeyer
Copy link

comment:49

I just tested again and this no longer causes #25969.

@jdemeyer
Copy link

Changed dependencies from #25504, #25505, #25542, #25554, #25555, #25969 to #25504, #25505, #25542, #25554, #25555

@vbraun
Copy link
Member

vbraun commented Aug 26, 2018

Changed branch from u/jdemeyer/move_matrices_to_new_coercion_model to b03b8bf

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants