New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move matrices to new coercion model #23719
Comments
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
comment:4
If you want progress on this, it would be good to review #24742. |
This comment has been minimized.
This comment has been minimized.
Changed dependencies from #24742 to none |
Author: Jeroen Demeyer |
comment:7
Working on this... |
comment:8
Vincent, since you created this ticket: are there any concrete issues that would be fixed by this? |
comment:9
My aim was to allow matrices on semi-rings (ie structure having |
comment:10
Replying to @videlec:
What do you mean with "allow"? And how would that be related to changing |
Commit: |
Dependencies: #25504 |
Branch pushed to git repo; I updated commit sha1. This was a forced push. Last 10 new commits:
|
comment:42
The error seems unrelated to this ticket. Somebody also got it because of the Singular upgrade, see #25969. |
comment:44
update milestone 8.3 -> 8.4 |
Branch pushed to git repo; I updated commit sha1 and set ticket back to needs_review. This was a forced push. New commits:
|
comment:49
I just tested again and this no longer causes #25969. |
Changed branch from u/jdemeyer/move_matrices_to_new_coercion_model to |
MatrixSpace
do not play well with the category framework. One step forward is to rename the attribute_matrix_class
toElement
so that it will haveelement_class
pointing to the element class generated viaParent.__init__
.Related tickets: #19669
Depends on #25504
Depends on #25505
Depends on #25542
Depends on #25554
Depends on #25555
CC: @tscrim
Component: coercion
Keywords: days94
Author: Jeroen Demeyer
Branch/Commit:
b03b8bf
Reviewer: Travis Scrimshaw
Issue created by migration from https://trac.sagemath.org/ticket/23719
The text was updated successfully, but these errors were encountered: