Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support new-style Parents in RingMap_lift #25554

Closed
jdemeyer opened this issue Jun 11, 2018 · 7 comments
Closed

Support new-style Parents in RingMap_lift #25554

jdemeyer opened this issue Jun 11, 2018 · 7 comments
Labels
c: coercion p: major / 3 t: bug
Milestone
sage-8.3

Comments

@jdemeyer
Copy link

The code for RingMap_lift uses some internal functions of the old coercion model (Parent_old). There is an example involving matrix spaces which breaks with #25319 because MatrixSpace becomes a new-style parent.

Instead, we should implement RingMap_lift using proper coercion maps, which are supported by the old and new coercion model.

Component: coercion

Author: Jeroen Demeyer

Branch/Commit: 15f31c0

Reviewer: Travis Scrimshaw

Issue created by migration from https://trac.sagemath.org/ticket/25554
@jdemeyer jdemeyer added this to the sage-8.3 milestone Jun 11, 2018
@jdemeyer
Copy link
Author

Branch: u/jdemeyer/support_new_style_parents_in_ringmap_lift

@jdemeyer
Copy link
Author

Commit: 15f31c0

@jdemeyer
Copy link
Author

New commits:

15f31c0Support new-style Parents in RingMap_lift

@tscrim
Copy link
Collaborator

tscrim commented Jun 12, 2018

Reviewer: Travis Scrimshaw

@tscrim
Copy link
Collaborator

tscrim commented Jun 12, 2018

comment:3

If a patchbot comes back good, you can set a positive review.

@jdemeyer
Copy link
Author

comment:4

#23719 passes the testsuite, so I'll assume that this one also does.

@vbraun
Copy link
Member

vbraun commented Jun 14, 2018

Changed branch from u/jdemeyer/support_new_style_parents_in_ringmap_lift to 15f31c0

@vbraun vbraun closed this as completed in 7c9d1f6 Jun 14, 2018
@videlec videlec mentioned this issue Aug 26, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
c: coercion p: major / 3 t: bug
Projects
None yet
Milestone
sage-8.3
Development

No branches or pull requests
3 participants
@vbraun @tscrim @jdemeyer