Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

py3: caring for some dict changing size #25595

Closed
fchapoton opened this issue Jun 17, 2018 · 13 comments
Closed

py3: caring for some dict changing size #25595

fchapoton opened this issue Jun 17, 2018 · 13 comments
Labels
c: python3 p: major / 3 t: enhancement
Milestone
sage-8.3

Comments

@fchapoton
Copy link
Contributor

CC: @tscrim @embray @jdemeyer

Component: python3

Author: Frédéric Chapoton

Branch/Commit: 174558c

Reviewer: Erik Bray, Jeroen Demeyer

Issue created by migration from https://trac.sagemath.org/ticket/25595
@fchapoton fchapoton added this to the sage-8.3 milestone Jun 17, 2018
@fchapoton
Copy link
Contributor Author

New commits:

26c5de6py3: caring for some dictionaries changing size during iteration

@fchapoton
Copy link
Contributor Author

Branch: u/chapoton/25595

@fchapoton
Copy link
Contributor Author

Commit: 26c5de6

@fchapoton
Copy link
Contributor Author

comment:2

bot is morally green

@jdemeyer
Copy link

comment:3

list(clusters.keys()) -> list(clusters)

@jdemeyer
Copy link

comment:4

Same for list(factors_by_degree.keys())

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jun 19, 2018

Branch pushed to git repo; I updated commit sha1. New commits:

df0bb52Merge branch 'u/chapoton/25595' in 8.3.b6
174558ctrac 25595 removing superfluous .keys()

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jun 19, 2018

Changed commit from 26c5de6 to 174558c

@fchapoton
Copy link
Contributor Author

comment:6

done, thanks

@fchapoton
Copy link
Contributor Author

comment:7

green bot

@embray
Copy link
Contributor

embray commented Jun 20, 2018

comment:8

Hm. I wonder what's going on with the docker patchbot. Maybe it needs to be updated to a newer base version of Sage...

@embray
Copy link
Contributor

embray commented Jun 20, 2018

Reviewer: Erik Bray, Jeroen Demeyer

@vbraun
Copy link
Member

vbraun commented Jun 21, 2018

Changed branch from u/chapoton/25595 to 174558c

@vbraun vbraun closed this as completed in 554d7fa Jun 21, 2018
@fchapoton fchapoton mentioned this issue Jun 29, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
c: python3 p: major / 3 t: enhancement
Projects
None yet
Milestone
sage-8.3
Development

No branches or pull requests
4 participants
@embray @vbraun @jdemeyer @fchapoton