Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

py3: caring for some dict changing size (step 2) #25669

Closed
fchapoton opened this issue Jun 27, 2018 · 12 comments
Closed

py3: caring for some dict changing size (step 2) #25669

fchapoton opened this issue Jun 27, 2018 · 12 comments
Labels
c: python3 p: major / 3 t: enhancement
Milestone
sage-8.3

Comments

@fchapoton
Copy link
Contributor

similar to #25595

CC: @embray @jdemeyer

Component: python3

Author: Frédéric Chapoton

Branch/Commit: 722edd0

Reviewer: Travis Scrimshaw

Issue created by migration from https://trac.sagemath.org/ticket/25669
@fchapoton fchapoton added this to the sage-8.3 milestone Jun 27, 2018
@fchapoton
Copy link
Contributor Author

New commits:

2daf5b7py3: more care for dictionary changing size

@fchapoton
Copy link
Contributor Author

Branch: u/chapoton/25669

@fchapoton
Copy link
Contributor Author

Commit: 2daf5b7

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jun 27, 2018

Branch pushed to git repo; I updated commit sha1. New commits:

fc1189fone more dict changing size

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jun 27, 2018

Changed commit from 2daf5b7 to fc1189f

@fchapoton
Copy link
Contributor Author

comment:3

I had forgotten one

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jun 27, 2018

Branch pushed to git repo; I updated commit sha1. New commits:

722edd0fix

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jun 27, 2018

Changed commit from fc1189f to 722edd0

@tscrim
Copy link
Collaborator

tscrim commented Jun 27, 2018

comment:5

LGTM.

@tscrim
Copy link
Collaborator

tscrim commented Jun 27, 2018

Reviewer: Travis Scrimshaw

@embray
Copy link
Contributor

embray commented Jun 27, 2018

comment:6

Great, thanks.

@vbraun
Copy link
Member

vbraun commented Jun 29, 2018

Changed branch from u/chapoton/25669 to 722edd0

@vbraun vbraun closed this as completed in f3cfdb8 Jun 29, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
c: python3 p: major / 3 t: enhancement
Projects
None yet
Milestone
sage-8.3
Development

No branches or pull requests
4 participants
@embray @vbraun @tscrim @fchapoton