Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding other versions to the burau_matrix method of the braid group class #25760

Closed
soehms opened this issue Jul 3, 2018 · 10 comments
Closed

Comments

@soehms
Copy link
Member

soehms commented Jul 3, 2018

  1. Version of the Burau matrix according to Wikipeda

  2. Unitary version according to: C. C. Squier:THE BURAU REPRESENTATION IS UNITARY, PROCEEDINGS OF THE AMERICAN MATHEMATICAL SOCIETY, Volume 90. Number 2, February 1984

CC: @miguelmarco @tscrim

Component: group theory

Keywords: days94

Author: Sebastian Oehms

Branch/Commit: cf4f640

Reviewer: Travis Scrimshaw

Issue created by migration from https://trac.sagemath.org/ticket/25760

@soehms soehms added this to the sage-8.3 milestone Jul 3, 2018
@soehms
Copy link
Member Author

soehms commented Jul 3, 2018

Author: Sebastian Oehms

@soehms
Copy link
Member Author

soehms commented Jul 13, 2018

Branch: u/soehms/burau_matrix

@soehms
Copy link
Member Author

soehms commented Jul 13, 2018

New commits:

567b955implement wikipedia and unitary version
6636298add the hermitian form
c1f5994add adjoined matrix
ec081e5corrections and doctest
6dc4264Merge branch 'develop' into burau_matrix

@soehms
Copy link
Member Author

soehms commented Jul 13, 2018

Commit: 6dc4264

@tscrim
Copy link
Collaborator

tscrim commented Jul 13, 2018

Changed commit from 6dc4264 to cf4f640

@tscrim
Copy link
Collaborator

tscrim commented Jul 13, 2018

comment:4

I made a few changes in a way I think is more natural by allowing reduced to take a string saying what reduced form to construct. If my changes are good, then positive review.


New commits:

cf4f640Doing a little reorganization.

@tscrim
Copy link
Collaborator

tscrim commented Jul 13, 2018

Changed branch from u/soehms/burau_matrix to public/groups/burau_matrix_types-25760

@tscrim
Copy link
Collaborator

tscrim commented Jul 13, 2018

Reviewer: Travis Scrimshaw

@soehms
Copy link
Member Author

soehms commented Jul 14, 2018

comment:5

Hi Travis,

thanks for reviewing this. I agree with all your improvements!

It's a good idea to integrate the new functionality into the reduced-option (I was thinking to much in types)! Also, the more precise description of the difference of the versions is very helpful.
Finally, thanks for your corrections with respect to formatting conventions. I hope I will learn them soon.

@vbraun
Copy link
Member

vbraun commented Aug 5, 2018

Changed branch from public/groups/burau_matrix_types-25760 to cf4f640

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants