Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adapt unitary burau matrix to Sage convention #26657

Closed
soehms opened this issue Nov 6, 2018 · 14 comments
Closed

Adapt unitary burau matrix to Sage convention #26657

soehms opened this issue Nov 6, 2018 · 14 comments

Comments

@soehms
Copy link
Member

soehms commented Nov 6, 2018

The unitary Burau matrix has been implemented in #25760. The choice between the two adjoined possibilities has been made according to the used literature ([Squ1984]_).

Unfortunately, this is opposite to the convention used in Sage for example in :meth:_check_matrix of :class:UnitaryMatrixGroup_generic.

This discrepancy is corrected by the ticket. A deprecation of the former behavior doesn't seem to be necessary, since the new functionality has been released just a couple of months ago.

CC: @tscrim

Component: group theory

Keywords: braid, burau, unitary

Author: Sebastian Oehms

Branch/Commit: a05e3e4

Reviewer: Travis Scrimshaw

Issue created by migration from https://trac.sagemath.org/ticket/26657

@soehms soehms added this to the sage-8.5 milestone Nov 6, 2018
@soehms
Copy link
Member Author

soehms commented Nov 6, 2018

Branch: u/soehms/adapt_unitary_burau-26657

@soehms
Copy link
Member Author

soehms commented Nov 6, 2018

Commit: be4674b

@soehms
Copy link
Member Author

soehms commented Nov 6, 2018

New commits:

be4674binitial implementation

@tscrim
Copy link
Collaborator

tscrim commented Dec 2, 2018

comment:3

Sorry, I lost track of this ticket. LGTM.

@tscrim
Copy link
Collaborator

tscrim commented Dec 2, 2018

Reviewer: Travis Scrimshaw

@tscrim
Copy link
Collaborator

tscrim commented Dec 2, 2018

comment:4

One little fix needed: :trac:`25760 -> :trac:`25760`. Once done, you can set to a positive review.

@soehms
Copy link
Member Author

soehms commented Dec 2, 2018

@soehms
Copy link
Member Author

soehms commented Dec 2, 2018

Changed commit from be4674b to none

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Dec 2, 2018

Commit: b36eca1

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Dec 2, 2018

Branch pushed to git repo; I updated commit sha1. New commits:

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Dec 2, 2018

Branch pushed to git repo; I updated commit sha1. New commits:

a05e3e4correct typset error in new branch to avoid merge error

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Dec 2, 2018

Changed commit from b36eca1 to a05e3e4

@soehms
Copy link
Member Author

soehms commented Dec 2, 2018

comment:8

Replying to @tscrim:

Sorry, I lost track of this ticket. LGTM.

No Problem!

Thank you, Travis! I will be waiting for the patchbot to see if I got rid of that merge error.

@vbraun
Copy link
Member

vbraun commented Dec 5, 2018

Changed branch from u/soehms/adapt_unitary_burau_26657 to a05e3e4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants