New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adapt unitary burau matrix to Sage convention #26657
Comments
Commit: |
New commits:
|
comment:3
Sorry, I lost track of this ticket. LGTM. |
Reviewer: Travis Scrimshaw |
comment:4
One little fix needed: |
Changed branch from u/soehms/adapt_unitary_burau-26657 to u/soehms/adapt_unitary_burau_26657 |
Changed commit from |
Commit: |
Branch pushed to git repo; I updated commit sha1. New commits: |
Branch pushed to git repo; I updated commit sha1. New commits:
|
comment:8
Replying to @tscrim:
No Problem! Thank you, Travis! I will be waiting for the patchbot to see if I got rid of that merge error. |
Changed branch from u/soehms/adapt_unitary_burau_26657 to |
The unitary Burau matrix has been implemented in #25760. The choice between the two adjoined possibilities has been made according to the used literature ([Squ1984]_).
Unfortunately, this is opposite to the convention used in Sage for example in :meth:
_check_matrix
of :class:UnitaryMatrixGroup_generic
.This discrepancy is corrected by the ticket. A deprecation of the former behavior doesn't seem to be necessary, since the new functionality has been released just a couple of months ago.
CC: @tscrim
Component: group theory
Keywords: braid, burau, unitary
Author: Sebastian Oehms
Branch/Commit:
a05e3e4
Reviewer: Travis Scrimshaw
Issue created by migration from https://trac.sagemath.org/ticket/26657
The text was updated successfully, but these errors were encountered: