-
-
Notifications
You must be signed in to change notification settings - Fork 454
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move gap packages to features #25835
Comments
comment:4
You probably know your code best. Could you maybe make that addition? Feel free to base off my branch and rebase as you like. |
Changed branch from u/gh-timokau/gap-features to u/tscrim/gap_features-25835 |
Reviewer: Travis Scrimshaw |
comment:6
LGTM (I'm assuming you ran the doctest?) :) Just as an FYI: My one nitpick would be the commit message. It should be in imperative and a bit more abstract, maybe "Use features to detect QuaGroup support" or something. But that's not a blocker. |
Changed branch from u/tscrim/gap_features-25835 to |
Split from #25825. This moves the remaining instances of
is_package_installed
for gap packages toFeature
s.CC: @tscrim @jdemeyer
Component: build
Author: Timo Kaufmann
Branch/Commit:
63363f0
Reviewer: Travis Scrimshaw
Issue created by migration from https://trac.sagemath.org/ticket/25835
The text was updated successfully, but these errors were encountered: