Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the ore_algebra optional package #26332

Closed
sagetrac-tmonteil mannequin opened this issue Sep 21, 2018 · 30 comments
Closed

Remove the ore_algebra optional package #26332

sagetrac-tmonteil mannequin opened this issue Sep 21, 2018 · 30 comments

Comments

@sagetrac-tmonteil
Copy link
Mannequin

sagetrac-tmonteil mannequin commented Sep 21, 2018

The version shipped by Sage has been out of date for a while and periodically breaks when Sage makes incompatible changes, while up-to-date versions can easily be installed from pip.

Now pip-available from https://github.com/mkauers/ore_algebra

CC: @mkauers @mezzarobba @slel

Component: packages: optional

Keywords: upgrade, ore_algebra

Author: Thierry Monteil, Marc Mezzarobba

Branch/Commit: 1f64d51

Reviewer: Frédéric Chapoton

Issue created by migration from https://trac.sagemath.org/ticket/26332

@sagetrac-tmonteil sagetrac-tmonteil mannequin added this to the sage-8.4 milestone Sep 21, 2018
@sagetrac-tmonteil
Copy link
Mannequin Author

sagetrac-tmonteil mannequin commented Sep 21, 2018

@sagetrac-tmonteil
Copy link
Mannequin Author

sagetrac-tmonteil mannequin commented Sep 21, 2018

Commit: ff802e2

@sagetrac-tmonteil
Copy link
Mannequin Author

sagetrac-tmonteil mannequin commented Sep 21, 2018

New commits:

ff802e226332 : fetch ore_algebra directly from upstream

@jdemeyer
Copy link

jdemeyer commented Oct 7, 2018

Replying to @sagetrac-tmonteil:

(A) ore_algebra 0.3 is not working with Sage for a wile and upstream does not release versions anymore.

(B) Hence, we should [...] fetch ore_algebra directly from upstream.

I don't see how premise (A) implies conclusion (B). There are other packages that don't have releasea and which are still packaged normally.

@jdemeyer

This comment has been minimized.

@slel
Copy link
Member

slel commented Jun 3, 2019

comment:5

New version: ore_algebra 0.4 was released on 2019-05-17.

Can someone test whether it installs and works with current Sage?

@slel
Copy link
Member

slel commented Jun 3, 2019

Changed keywords from none to upgrade, ore_algebra

@slel

This comment has been minimized.

@slel slel changed the title fetch ore_algebra directly from upstream Upgrade: ore_algebra 0.4 Jun 3, 2019
@slel slel modified the milestones: sage-8.4, sage-8.8 Jun 3, 2019
@slel

This comment has been minimized.

@mezzarobba
Copy link
Member

comment:7

Not tested.


New commits:

8de39b6#26332 Remove the ore_algebra package

@mezzarobba
Copy link
Member

Changed author from Thierry Monteil to Thierry Monteil, Marc Mezzarobba

@mezzarobba
Copy link
Member

Changed commit from ff802e2 to 8de39b6

@mezzarobba
Copy link
Member

@mezzarobba

This comment has been minimized.

@mezzarobba mezzarobba changed the title Upgrade: ore_algebra 0.4 Remove the ore_algebra optional package Jun 3, 2019
@mezzarobba

This comment has been minimized.

@jdemeyer
Copy link

jdemeyer commented Jun 3, 2019

comment:9

Why remove the package instead of upgrading, as Samuel proposed?

@mezzarobba
Copy link
Member

comment:10

Replying to @jdemeyer:

Why remove the package instead of upgrading, as Samuel proposed?

It is an external package with a dependency on Sage. I think people should install it from pip or whatever they like; I don't see the point of having it as a Sage package. And while I try to make sure that the master branch always works with the latest Sage release, the Sage package is broken half of the time. If someone wants to take care of it on a regular basis (and bug Manuel to tag a point release every time something breaks), that's fine with me of course, but that hasn't been the case in the last few years.

@jdemeyer
Copy link

jdemeyer commented Jun 3, 2019

comment:11

Replying to @mezzarobba:

I think people should install it from pip or whatever they like; I don't see the point of having it as a Sage package.

There are many packages for which this argument could be made, but we still ship them as Sage packages. The advantages of having a Sage package are user friendliness (sage -i ore_algebra works) and automatic updates with version checking.

I try to make sure that the master branch always works with the latest Sage release

But not everybody uses the latest Sage release. You may break stuff if a newer version of ore_algebra doesn't work with an older version of Sage.

@mezzarobba
Copy link
Member

comment:12

Replying to @jdemeyer:

Replying to @mezzarobba:

I think people should install it from pip or whatever they like; I don't see the point of having it as a Sage package.

There are many packages for which this argument could be made, but we still ship them as Sage packages. The advantages of having a Sage package are user friendliness (sage -i ore_algebra works) and automatic updates with version checking.

If it works, yes, except that I personally consider sage -i a strictly less user-friendly option than sage -pip install (< pip install < apt install).

I try to make sure that the master branch always works with the latest Sage release

But not everybody uses the latest Sage release. You may break stuff if a newer version of ore_algebra doesn't work with an older version of Sage.

Yes, of course. I'm alking about the master branch... Fwiw I also try to keep it compatible with earlier versions when that's easy to do.

@mezzarobba
Copy link
Member

comment:13

(If anyone really considers it important to have ore_algebra as a Sage package, feel free to revert my changes to this ticket.)

PS regarding Thierry's version: I personally don't like the idea of a “package” that actually installs a version that was not checked by the packager, but I won't argue if people want that.

@mezzarobba
Copy link
Member

comment:14

So: If someone prefers the status quo or Thierry's original solution to removing the package, could you please state it clearly? Otherwise, this should be an easy review... Thanks!

@embray
Copy link
Contributor

embray commented Jul 3, 2019

comment:15

Moving tickets from the Sage 8.8 milestone that have been actively worked on in the last six months to the next release milestone (optimistically).

@embray embray modified the milestones: sage-8.8, sage-8.9 Jul 3, 2019
@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Dec 17, 2019

Changed commit from 8de39b6 to 1f64d51

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Dec 17, 2019

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

1f64d51#26332 Remove the ore_algebra package

@fchapoton
Copy link
Contributor

comment:17

ok, let it go

@fchapoton
Copy link
Contributor

Reviewer: Frédéric Chapoton

@fchapoton

This comment has been minimized.

@fchapoton
Copy link
Contributor

Changed reviewer from Frédéric Chapoton to none

@fchapoton
Copy link
Contributor

Reviewer: Frédéric Chapoton

@fchapoton fchapoton modified the milestones: sage-8.9, sage-9.0 Dec 17, 2019
@vbraun
Copy link
Member

vbraun commented Dec 20, 2019

Changed branch from u/mmezzarobba/remove_ore_algebra to 1f64d51

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants