New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove the ore_algebra optional package #26332
Comments
Commit: |
New commits:
|
Replying to @sagetrac-tmonteil:
I don't see how premise (A) implies conclusion (B). There are other packages that don't have releasea and which are still packaged normally. |
This comment has been minimized.
This comment has been minimized.
comment:5
New version: Can someone test whether it installs and works with current Sage? |
Changed keywords from none to upgrade, ore_algebra |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
comment:7
Not tested. New commits:
|
Changed author from Thierry Monteil to Thierry Monteil, Marc Mezzarobba |
Changed branch from u/tmonteil/fetch_ore_algebra_directly_from_upstream to u/mmezzarobba/remove_ore_algebra |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
comment:9
Why remove the package instead of upgrading, as Samuel proposed? |
comment:10
Replying to @jdemeyer:
It is an external package with a dependency on Sage. I think people should install it from pip or whatever they like; I don't see the point of having it as a Sage package. And while I try to make sure that the master branch always works with the latest Sage release, the Sage package is broken half of the time. If someone wants to take care of it on a regular basis (and bug Manuel to tag a point release every time something breaks), that's fine with me of course, but that hasn't been the case in the last few years. |
comment:11
Replying to @mezzarobba:
There are many packages for which this argument could be made, but we still ship them as Sage packages. The advantages of having a Sage package are user friendliness (
But not everybody uses the latest Sage release. You may break stuff if a newer version of |
comment:12
Replying to @jdemeyer:
If it works, yes, except that I personally consider
Yes, of course. I'm alking about the master branch... Fwiw I also try to keep it compatible with earlier versions when that's easy to do. |
comment:13
(If anyone really considers it important to have ore_algebra as a Sage package, feel free to revert my changes to this ticket.) PS regarding Thierry's version: I personally don't like the idea of a “package” that actually installs a version that was not checked by the packager, but I won't argue if people want that. |
comment:14
So: If someone prefers the status quo or Thierry's original solution to removing the package, could you please state it clearly? Otherwise, this should be an easy review... Thanks! |
comment:15
Moving tickets from the Sage 8.8 milestone that have been actively worked on in the last six months to the next release milestone (optimistically). |
Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:
|
comment:17
ok, let it go |
Reviewer: Frédéric Chapoton |
This comment has been minimized.
This comment has been minimized.
Changed reviewer from Frédéric Chapoton to none |
Reviewer: Frédéric Chapoton |
Changed branch from u/mmezzarobba/remove_ore_algebra to |
The version shipped by Sage has been out of date for a while and periodically breaks when Sage makes incompatible changes, while up-to-date versions can easily be installed from pip.
Now pip-available from https://github.com/mkauers/ore_algebra
CC: @mkauers @mezzarobba @slel
Component: packages: optional
Keywords: upgrade, ore_algebra
Author: Thierry Monteil, Marc Mezzarobba
Branch/Commit:
1f64d51
Reviewer: Frédéric Chapoton
Issue created by migration from https://trac.sagemath.org/ticket/26332
The text was updated successfully, but these errors were encountered: