py3: some care for integer.pyx

[fchapoton]

where hex, oct, long, hash are problematic.

Here we take care only of hex and long.

CC: @tscrim @jdemeyer @embray

Component: python3

Author: Frédéric Chapoton

Branch/Commit: 394817c

Reviewer: Travis Scrimshaw, Erik Bray

Issue created by migration from https://trac.sagemath.org/ticket/26756

[fchapoton]

New commits:

a98f30b

some fixes and deprecation for hex / oct of Integer

[fchapoton]

Author: Frédéric Chapoton

[fchapoton]

Branch: u/chapoton/26756

[fchapoton]

Commit: a98f30b

[sagetrac-git]

Branch pushed to git repo; I updated commit sha1. New commits:

3b81648

fixing doctests for hex and oct in lazy_import

[sagetrac-git]

Changed commit from a98f30b to 3b81648

[tscrim]

comment:3

LGTM.

[tscrim]

Reviewer: Travis Scrimshaw

[embray]

comment:4

The changes to LazyImport are not right. I agree with not using the hex() and oct() built-ins here. Rather, it should just pass to self.get_object.__hex__() and __oct__() respectively; there's no guarantee that the proxied object has .oct() or .hex() methods.

This is meant to be pretty a pretty generic proxy class (in fact I have a ticket I would like to revive sometime where I reimplement this on an existing proxy library for Python: #22793).

[fchapoton]

comment:5

Hello Erik. Glad to see you back. Would you please look at #26740 ?

Here are the only remaining __hex__ in sage:

chapoton@pc-chapoton:~/sage$ git grep "def __hex__(" src/sage
src/sage/libs/ntl/ntl_GF2X.pyx:    def __hex__(self):
src/sage/misc/lazy_import.pyx:    def __hex__(self):
src/sage/rings/integer.pyx:    def __hex__(self):
src/sage/rings/real_mpfr.pyx:    def __hex__(self):

and we also have

src/sage/libs/ntl/ntl_GF2X.pyx:    def hex(ntl_GF2X self):
src/sage/rings/real_mpfr.pyx:    def hex(self):

I think the __hex__ should all disappear. In python3, hex call the __index__ method.

[embray]

comment:6

I never went away really. I've just been working on other stuff (mainly related to GAP). But I thought I should try to take a day or two to catch up on other things :)

That's a good point. You could also leave __hex__ and __oct__ as they were previously, but they should be bracketed with a Cython-level if like IF PY_MAJOR_VERSION < 3:.

[sagetrac-git]

Branch pushed to git repo; I updated commit sha1. New commits:

b406d22	Merge branch 'u/chapoton/26756' in 8.5.b6
394817c	trac 26756 some changes in `__hex__`, `__oct__` for lazy imports

[sagetrac-git]

Changed commit from 3b81648 to 394817c

[fchapoton]

comment:8

better like this, Erik ?

[embray]

comment:9

Okay, thanks!

[embray]

Changed reviewer from Travis Scrimshaw to Travis Scrimshaw, Erik Bray

[vbraun]

Changed branch from u/chapoton/26756 to 394817c