Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

vertices should not default to red #2684

Closed
jasongrout opened this issue Mar 27, 2008 · 6 comments
Closed

vertices should not default to red #2684

jasongrout opened this issue Mar 27, 2008 · 6 comments
Assignees
@rlmill
Labels
c: graph theory p: minor / 4 t: bug
Milestone
sage-3.0.2

Comments

@jasongrout
Copy link
Member

A student has brought up that having vertices default to red makes the number labels very difficult to read, especially for visually-impaired people.

Component: graph theory

Issue created by migration from https://trac.sagemath.org/ticket/2684
@jasongrout jasongrout added this to the sage-3.0.2 milestone Mar 27, 2008
@jasongrout
Copy link
Member Author

comment:1

The student said that yellow or even pale pink would work much better.

@jasongrout
Copy link
Member Author

comment:2

See the extensive discussion at http://groups.google.com/group/sage-devel/browse_thread/thread/87cc5791e7014de8/bf77357d2e33f0a5 for feedback.

@jasongrout
Copy link
Member Author

Attachment: trac-2684-vertex-colors.patch.gz

@jasongrout
Copy link
Member Author

comment:3

Based on the mailing list conversation, of the two visually-impaired people that looked at the colors, there was:

  • Pink: 1 positive and 1 neutral vote
  • Blue: 1 positive and 1 neutral vote
  • Yellow: 1 positive and 1 negative

I made the default pink and the boundary vertices default to blue.

@rlmill
Copy link
Mannequin

rlmill mannequin commented May 10, 2008

comment:4

No new doctests, but I don't see how to do that for this patch anyway. Apply.

@sagetrac-mabshoff
Copy link
Mannequin

sagetrac-mabshoff mannequin commented May 11, 2008

comment:5

Merged in Sage 3.0.2.alpha0

@sagetrac-mabshoff sagetrac-mabshoff mannequin closed this as completed May 11, 2008
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rlmill rlmill

Labels
c: graph theory p: minor / 4 t: bug
Projects
None yet
Milestone
sage-3.0.2
Development

No branches or pull requests
1 participant
@jasongrout