Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

LatticePoset, error in is_supersolvable() with certificate=True #26857

Closed
jm58660 mannequin opened this issue Dec 8, 2018 · 9 comments
Closed

LatticePoset, error in is_supersolvable() with certificate=True #26857

jm58660 mannequin opened this issue Dec 8, 2018 · 9 comments
Labels
c: combinatorics p: major / 3 t: bug
Milestone
sage-8.6

Comments

@jm58660
Copy link
Mannequin

jm58660 mannequin commented Dec 8, 2018 

hex = LatticePoset({1: [2, 3], 2: [4], 3: [5], 4: [6], 5: [6]})
hex.is_supersolvable(certificate=True)

outputs plain False, but it should output (False, None).

CC: @mantepse

Component: combinatorics

Author: Jori Mäntysalo

Branch/Commit: e3aa0ed

Reviewer: Frédéric Chapoton

Issue created by migration from https://trac.sagemath.org/ticket/26857
@jm58660 jm58660 mannequin added this to the sage-8.5 milestone Dec 8, 2018
@jm58660 jm58660 mannequin added c: combinatorics labels Dec 8, 2018
@jm58660
Copy link
Mannequin Author

jm58660 mannequin commented Dec 8, 2018

Branch: u/jmantysalo/supersolvable-cert

@jm58660
Copy link
Mannequin Author

jm58660 mannequin commented Dec 8, 2018

Commit: e3aa0ed

@jm58660
Copy link
Mannequin Author

jm58660 mannequin commented Dec 8, 2018

comment:2

Done without compiling...

New commits:

e3aa0edAlways return a pair when certificate=True

@jm58660 jm58660 mannequin added the s: needs review label Dec 8, 2018
@fchapoton
Copy link
Contributor

comment:3

green bot => positive review

@fchapoton
Copy link
Contributor

Author: Jori Mäntysalo

@fchapoton
Copy link
Contributor

Reviewer: Frédéric Chapoton

@jm58660
Copy link
Mannequin Author

jm58660 mannequin commented Dec 9, 2018

comment:5

Thanks.

I tested with all lattices up to 9 elements, and there was no more errors of this .is_something(certificate=True) -type.

@vbraun
Copy link
Member

vbraun commented Dec 23, 2018

Changed branch from u/jmantysalo/supersolvable-cert to e3aa0ed

@vbraun vbraun closed this as completed in 3e002dd Dec 23, 2018
@embray
Copy link
Contributor

embray commented Dec 28, 2018

comment:7

This tickets were closed as fixed after the Sage 8.5 release.

@embray embray modified the milestones: sage-8.5, sage-8.6 Dec 28, 2018
@jm58660 jm58660 mannequin mentioned this issue Dec 30, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
c: combinatorics p: major / 3 t: bug
Projects
None yet
Milestone
sage-8.6
Development

No branches or pull requests
4 participants
@embray @vbraun @tscrim @fchapoton